mbox series

[0/2] block: improve the share tag set performance

Message ID 20230509065230.32552-1-ed.tsai@mediatek.com (mailing list archive)
Headers show
Series block: improve the share tag set performance | expand

Message

Ed Tsai (蔡宗軒) May 9, 2023, 6:52 a.m. UTC 
The tag allocation is limited by the number of active queues and a
queue is marked as inactive by the queue timeout worker after up to 30Hz
by default.

UFS devices have multiple logical units, and they can limit the depth of
data LUNs by the fair tag sharing algorithm. Make the fair tag sharing
configurable and improve the performance for UFS devices.

See also https://lore.kernel.org/all/20230103195337.158625-1-bvanassche@acm.org

Ed Tsai (2):
  block: make the fair sharing of tag configurable
  ufs: don't use the fair tag sharings

 block/blk-mq-debugfs.c    | 1 +
 block/blk-mq-tag.c        | 1 +
 block/blk-mq.c            | 3 ++-
 drivers/ufs/core/ufshcd.c | 3 +++
 include/linux/blkdev.h    | 6 +++++-
 5 files changed, 12 insertions(+), 2 deletions(-)

Comments

Bart Van Assche May 10, 2023, 10:56 p.m. UTC | #1 
On 5/8/23 23:52, Ed Tsai wrote:
> The tag allocation is limited by the number of active queues and a
> queue is marked as inactive by the queue timeout worker after up to 30Hz
> by default.
> 
> UFS devices have multiple logical units, and they can limit the depth of
> data LUNs by the fair tag sharing algorithm. Make the fair tag sharing
> configurable and improve the performance for UFS devices.
> 
> See also https://lore.kernel.org/all/20230103195337.158625-1-bvanassche@acm.org

Hi Jens,

This patch series is slightly more complicated than the patch that I 
posted in January. Do you prefer the approach of this patch series or 
rather the approach of the patch that I posted in January?

Thank you,

Bart.