mbox series

[V3,0/7] ublk: cleanup and support user copy

Message ID 20230519065030.351216-1-ming.lei@redhat.com (mailing list archive)
Headers show
Series ublk: cleanup and support user copy | expand

Message

Ming Lei May 19, 2023, 6:50 a.m. UTC 
Hello,

The 1st 3 patch are cleanup.

The other patches support to move data copy between io request pages and
userspace buffer into ublk server(userspace). This way avoids one round trip
of uring command(UBLK_F_NEED_GET_DATA), and solve buffer release issue for
READ[1]. Meantime both sides becomes cleaner. Also it can be thought as
prep patch for supporting zero copy.

ublksrv loop usercopy code:

	https://github.com/ming1/ubdsrv/commits/usercopy

[1] https://lore.kernel.org/linux-block/116d8a56-0881-56d3-9bcc-78ff3e1dc4e5@linux.alibaba.com/T/#m23bd4b8634c0a054e6797063167b469949a247bb


V3:
	- rebase on for-6.5/block
	- run xfstests and not see regression

V2:
	- rebase on latest linus tree


Ming Lei (7):
  ublk: kill queuing request by task_work_add
  ublk: cleanup io cmd code path by adding ublk_fill_io_cmd()
  ublk: cleanup ublk_copy_user_pages
  ublk: grab request reference when the request is handled by userspace
  ublk: support to copy any part of request pages
  ublk: add read()/write() support for ublk char device
  ublk: support user copy

 drivers/block/ublk_drv.c      | 457 +++++++++++++++++++++++++---------
 include/uapi/linux/ublk_cmd.h |  25 +-
 2 files changed, 361 insertions(+), 121 deletions(-)

Comments

Jens Axboe May 20, 2023, 2:04 a.m. UTC | #1 
On Fri, 19 May 2023 14:50:23 +0800, Ming Lei wrote:
> The 1st 3 patch are cleanup.
> 
> The other patches support to move data copy between io request pages and
> userspace buffer into ublk server(userspace). This way avoids one round trip
> of uring command(UBLK_F_NEED_GET_DATA), and solve buffer release issue for
> READ[1]. Meantime both sides becomes cleaner. Also it can be thought as
> prep patch for supporting zero copy.
> 
> [...]

Applied, thanks!

[1/7] ublk: kill queuing request by task_work_add
      (no commit info)
[2/7] ublk: cleanup io cmd code path by adding ublk_fill_io_cmd()
      (no commit info)
[3/7] ublk: cleanup ublk_copy_user_pages
      (no commit info)
[4/7] ublk: grab request reference when the request is handled by userspace
      (no commit info)
[5/7] ublk: support to copy any part of request pages
      (no commit info)
[6/7] ublk: add read()/write() support for ublk char device
      (no commit info)
[7/7] ublk: support user copy
      (no commit info)

Best regards,