[v12,0/3] Amiga RDB partition support fixes

Message

Michael Schmitz June 16, 2023, 10:36 p.m. UTC

Hi Jens,

the hopefully last version of this patch series, only change
in this version is to change all 32 bit fields in the
affs_hardblocks.h header to __be32 following review comments
by Christoph and Geert.

The simple fix (patch 1) still leaves ample room for overflows in
calculating start address and size of a RDB partition, though
such overflows should only be seen in rather unusual cases.

To address these potential overflows, checks are added in the
third patch of this series. Comments by Geert have been
addressed in full. 

In order to avoid warnings about a cast to a restricted
type (__be32, inside be32_to_cpu()) introduced by the third
patch, the second patch changes the annotation of all 32 bit
fields to __be32 (which is what these fields in the RDB
struct ought to have been in the first instance). 

Reviewed-by tags by Geert and Christoph added. Fixes and
prerequisites for stable backport also added. 

Cheers,

        Michael

Michael Schmitz (3):
  block: fix signed int overflow in Amiga partition support
  block: change annotation of rdb_CylBlocks in affs_hardblocks.h
  block: add overflow checks for Amiga partition support

 block/partitions/amiga.c             | 102 ++++++++++++++++++++++-----
 include/uapi/linux/affs_hardblocks.h |  68 +++++++++---------
 2 files changed, 119 insertions(+), 51 deletions(-)