[0/5] Improve checks in blk_revalidate_disk_zones()

Message

Damien Le Moal June 29, 2023, 6:25 a.m. UTC

This series slightly modifies the 4 block device drivers that support
zoned block devices to ensure that they all call
blk_revalidate_disk_zones() with the zone size and max zone append
limits set. This is done in the first 4 patches.

With these changes, the last patch improves blk_revalidate_disk_zones()
to better check a zoned device zones and the device limits.

Damien Le Moal (5):
  scsi: sd_zbc: Set zone limits before revalidating zones
  nvme: zns: Set zone limits before revalidating zones
  block: nullblk: Set zone limits before revalidating zones
  block: virtio_blk: Set zone limits before revalidating zones
  block: improve checks in blk_revalidate_disk_zones()

 block/blk-zoned.c              | 99 +++++++++++++++++++++-------------
 drivers/block/null_blk/zoned.c | 21 +++-----
 drivers/block/virtio_blk.c     | 35 ++++++------
 drivers/nvme/host/zns.c        |  9 ++--
 drivers/scsi/sd_zbc.c          | 12 ++---
 5 files changed, 96 insertions(+), 80 deletions(-)

Comments

Bart Van Assche June 29, 2023, 5:27 p.m. UTC | #1

On 6/28/23 23:25, Damien Le Moal wrote:
> This series slightly modifies the 4 block device drivers that support
> zoned block devices to ensure that they all call
> blk_revalidate_disk_zones() with the zone size and max zone append
> limits set. This is done in the first 4 patches.
> 
> With these changes, the last patch improves blk_revalidate_disk_zones()
> to better check a zoned device zones and the device limits.

This patch series changes a lot of code without making it very clear what
the advantages of this patch series are. The cover letter says "better
check" without explaining what is improved. The description of patch 5/5
says "the zone checks implemented in blk_revalidate_zone_cb() can be
improved" without explaining what is improved.

More information about what has been improved and why these improvements
are considered useful would be welcome.

Thanks,

Bart.