| Message ID | 20230913151616.3164338-1-chengming.zhou@linux.dev (mailing list archive) |
|---|---|
| Headers | show |
| Series | blk-mq: optimize queue_rqs() support | expand |
On Wed, 13 Sep 2023 15:16:11 +0000, chengming.zhou@linux.dev wrote: > Changes in v2: > - Drop the patch that fixes a potential race in request timeout > from this series. > - Rebased on the newest block/for-next branch. > > The current queue_rqs() support has limitation that it can't work on > shared tags queue, which is resolved by patch 1-3. We move the account > of active requests to where we really allocate the driver tag. > > [...] Applied, thanks! [1/5] blk-mq: account active requests when get driver tag commit: b8643d682669994b3f57c3440df3d4f9cb735f35 [2/5] blk-mq: remove RQF_MQ_INFLIGHT commit: 48554df6bf2b1e83f70749bf4b4d7914f8b3c01d [3/5] blk-mq: support batched queue_rqs() on shared tags queue commit: 434097ee375fff36bc5037524609ffd6199f11da [4/5] blk-mq: update driver tags request table when start request commit: 217b613a53d3a430aa2e5d1523819dc271f02ff0 [5/5] block/null_blk: add queue_rqs() support commit: d78bfa1346ab1fe04d20aa45a0678d1fc866f37c Best regards,
From: Chengming Zhou <zhouchengming@bytedance.com> Changes in v2: - Drop the patch that fixes a potential race in request timeout from this series. - Rebased on the newest block/for-next branch. The current queue_rqs() support has limitation that it can't work on shared tags queue, which is resolved by patch 1-3. We move the account of active requests to where we really allocate the driver tag. This is clearer and matched with the unaccount side which now happen when we put the driver tag. And we can remove RQF_MQ_INFLIGHT, which was used to avoid double account problem of flush request. Another problem is that the driver that support queue_rqs() has to set inflight request table by itself, which is resolved in patch 4. The last patch add queue_rqs() support for null_blk, which showed 3.6% IOPS improvement in fio/t/io_uring benchmark on my test VM. And we also use it for testing queue_rqs() on shared tags queue. Thanks for review! Chengming Zhou (5): blk-mq: account active requests when get driver tag blk-mq: remove RQF_MQ_INFLIGHT blk-mq: support batched queue_rqs() on shared tags queue blk-mq: update driver tags request table when start request block/null_blk: add queue_rqs() support block/blk-flush.c | 11 ++----- block/blk-mq-debugfs.c | 1 - block/blk-mq.c | 45 +++++++++------------------ block/blk-mq.h | 57 ++++++++++++++++++++++++----------- drivers/block/null_blk/main.c | 20 ++++++++++++ drivers/block/virtio_blk.c | 2 -- drivers/nvme/host/pci.c | 1 - include/linux/blk-mq.h | 2 -- 8 files changed, 76 insertions(+), 63 deletions(-)