mbox series

[0/3] partitions/ibm: Replace strncpy() and cleanups

Message ID 20230915131001.697070-1-sth@linux.ibm.com (mailing list archive)
Headers show
Series partitions/ibm: Replace strncpy() and cleanups | expand

Message

Stefan Haberland Sept. 15, 2023, 1:09 p.m. UTC
Hi Jens,

please apply the following patches for the next merge window that remove
strncpy() from DASD partition detection. This includes some cleanups that
should increase readability of the code.

This is based on the discussion started with the patches by Justin Stitt:
https://lore.kernel.org/linux-s390/20230822-strncpy-block-partitions-cmdline-ibm-v1-1-154dea8f755c@google.com/
https://lore.kernel.org/linux-s390/20230823-strncpy-block-partitions-cmdline-ibm-v2-1-40c77f7182fc@google.com/

Thanks.

Jan Höppner (3):
  partitions/ibm: Remove unnecessary memset
  partitions/ibm: Replace strncpy() and improve readability
  partitions/ibm: Introduce defines for magic string length values

 block/partitions/ibm.c | 98 +++++++++++++++++++++++++++++-------------
 1 file changed, 68 insertions(+), 30 deletions(-)

Comments

Stefan Haberland Oct. 4, 2023, 9:59 a.m. UTC | #1
Am 15.09.23 um 15:09 schrieb Stefan Haberland:
> Hi Jens,
>
> please apply the following patches for the next merge window that remove
> strncpy() from DASD partition detection. This includes some cleanups that
> should increase readability of the code.
>
> This is based on the discussion started with the patches by Justin Stitt:
> https://lore.kernel.org/linux-s390/20230822-strncpy-block-partitions-cmdline-ibm-v1-1-154dea8f755c@google.com/
> https://lore.kernel.org/linux-s390/20230823-strncpy-block-partitions-cmdline-ibm-v2-1-40c77f7182fc@google.com/
>
> Thanks.
>
> Jan Höppner (3):
>    partitions/ibm: Remove unnecessary memset
>    partitions/ibm: Replace strncpy() and improve readability
>    partitions/ibm: Introduce defines for magic string length values
>
>   block/partitions/ibm.c | 98 +++++++++++++++++++++++++++++-------------
>   1 file changed, 68 insertions(+), 30 deletions(-)
>

Hi Jens,

polite ping.
Any objections against the patches?

regards,
Stefan
Jens Axboe Oct. 4, 2023, 2:04 p.m. UTC | #2
On Fri, 15 Sep 2023 15:09:58 +0200, Stefan Haberland wrote:
> please apply the following patches for the next merge window that remove
> strncpy() from DASD partition detection. This includes some cleanups that
> should increase readability of the code.
> 
> This is based on the discussion started with the patches by Justin Stitt:
> https://lore.kernel.org/linux-s390/20230822-strncpy-block-partitions-cmdline-ibm-v1-1-154dea8f755c@google.com/
> https://lore.kernel.org/linux-s390/20230823-strncpy-block-partitions-cmdline-ibm-v2-1-40c77f7182fc@google.com/
> 
> [...]

Applied, thanks!

[1/3] partitions/ibm: Remove unnecessary memset
      commit: d323c1a9477a82843795f10fb23f1634cea44007
[2/3] partitions/ibm: Replace strncpy() and improve readability
      commit: f5f43aae6f336ae436759144a31879375e65ed28
[3/3] partitions/ibm: Introduce defines for magic string length values
      commit: a31281acc4a4e051a0bf2f1d3556ba4deea4d2a0

Best regards,
Jens Axboe Oct. 4, 2023, 2:04 p.m. UTC | #3
On 10/4/23 3:59 AM, Stefan Haberland wrote:
> Am 15.09.23 um 15:09 schrieb Stefan Haberland:
>> Hi Jens,
>>
>> please apply the following patches for the next merge window that remove
>> strncpy() from DASD partition detection. This includes some cleanups that
>> should increase readability of the code.
>>
>> This is based on the discussion started with the patches by Justin Stitt:
>> https://lore.kernel.org/linux-s390/20230822-strncpy-block-partitions-cmdline-ibm-v1-1-154dea8f755c@google.com/
>> https://lore.kernel.org/linux-s390/20230823-strncpy-block-partitions-cmdline-ibm-v2-1-40c77f7182fc@google.com/
>>
>> Thanks.
>>
>> Jan H?ppner (3):
>>    partitions/ibm: Remove unnecessary memset
>>    partitions/ibm: Replace strncpy() and improve readability
>>    partitions/ibm: Introduce defines for magic string length values
>>
>>   block/partitions/ibm.c | 98 +++++++++++++++++++++++++++++-------------
>>   1 file changed, 68 insertions(+), 30 deletions(-)
>>
> 
> Hi Jens,
> 
> polite ping.
> Any objections against the patches?

Nope, just had some travel and it got lost in the inbox. Now applied.