| Message ID | 20231219000815.2739120-1-bvanassche@acm.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Pass data lifetime information to SCSI disk devices | expand |
On 12/18/23 5:07 PM, Bart Van Assche wrote: > Hi Martin, > > UFS vendors need the data lifetime information to achieve good performance. > Providing data lifetime information to UFS devices can result in up to 40% > lower write amplification. Hence this patch series that adds support in F2FS > and also in the block layer for data lifetime information. The SCSI disk (sd) > driver is modified such that it passes write hint information to SCSI devices > via the GROUP NUMBER field. > > Please consider this patch series for the next merge window. Bart, can you please stop reposting so quickly, it achieves the opposite of what I suspect you are looking for.
On 12/18/23 17:12, Jens Axboe wrote: > Bart, can you please stop reposting so quickly, it achieves the opposite > of what I suspect you are looking for. Got it. I will repost less frequently. Jens, can you please help with reviewing patches 5 and 6 of this series? I think that's what most important right now to help this patch series to make progress. Thank you, Bart.
Hi Martin, UFS vendors need the data lifetime information to achieve good performance. Providing data lifetime information to UFS devices can result in up to 40% lower write amplification. Hence this patch series that adds support in F2FS and also in the block layer for data lifetime information. The SCSI disk (sd) driver is modified such that it passes write hint information to SCSI devices via the GROUP NUMBER field. Please consider this patch series for the next merge window. Thank you, Bart. Changes compared to v7: - As requested by Dave Chinner, changed one occurrence of file_inode(dio->iocb->ki_filp)->i_write_hint into inode->i_write_hint. - Modified the description of patch 03/19 since the patch that restores F_[GS]ET_FILE_RW_HINT has been removed. - Added Reviewed-by tags from v6 of this patch series and that were missing when v7 was posted. Changes compared to v6: - Dropped patch "fs: Restore F_[GS]ET_FILE_RW_HINT support". Changes compared to v5: - Added compile-time tests that compare the WRITE_LIFE_* and RWH_* constants. - Split the F_[GS]ET_RW_HINT handlers. - Removed the structure member kiocb.ki_hint again. Instead, copy the data lifetime information directly from struct file into a bio. - Together with Doug Gilbert, fixed multiple bugs in the scsi_debug patches. Added Doug's Tested-by. - Changed the type of "rscs:1" from bool into unsigned. - Added unit tests for the new SCSI protocol data structures. - Improved multiple patch descriptions. Changes compared to v4: - Dropped the patch that renames the WRITE_LIFE_* constants. - Added a fix for an argument check in fcntl_rw_hint(). - Reordered the patches that restore data lifetime support. - Included a fix for data lifetime support for buffered I/O to raw block devices. Changes compared to v3: - Renamed the data lifetime constants (WRITE_LIFE_*). - Fixed a checkpatch complaint by changing "unsigned" into "unsigned int". - Rebased this patch series on top of kernel v6.7-rc1. Changes compared to v2: - Instead of storing data lifetime information in bi_ioprio, introduce the new struct bio member bi_lifetime and also the struct request member 'lifetime'. - Removed the bio_set_data_lifetime() and bio_get_data_lifetime() functions and replaced these with direct assignments. - Dropped all changes related to I/O priority. - Improved patch descriptions. Changes compared to v1: - Use six bits from the ioprio field for data lifetime information. The bio->bi_write_hint / req->write_hint / iocb->ki_hint members that were introduced in v1 have been removed again. - The F_GET_FILE_RW_HINT and F_SET_FILE_RW_HINT fcntls have been removed. - In the SCSI disk (sd) driver, query the stream status and check the PERM bit. - The GET STREAM STATUS command has been implemented in the scsi_debug driver. Bart Van Assche (19): fs: Fix rw_hint validation fs: Verify write lifetime constants at compile time fs: Split fcntl_rw_hint() fs: Move enum rw_hint into a new header file block, fs: Restore the per-bio/request data lifetime fields block, fs: Propagate write hints to the block device inode fs/f2fs: Restore the whint_mode mount option fs/f2fs: Restore support for tracing data lifetimes scsi: core: Query the Block Limits Extension VPD page scsi: scsi_proto: Add structures and constants related to I/O groups and streams scsi: sd: Translate data lifetime information scsi: scsi_debug: Reduce code duplication scsi: scsi_debug: Support the block limits extension VPD page scsi: scsi_debug: Rework page code error handling scsi: scsi_debug: Rework subpage code error handling scsi: scsi_debug: Allocate the MODE SENSE response from the heap scsi: scsi_debug: Implement the IO Advice Hints Grouping mode page scsi: scsi_debug: Implement GET STREAM STATUS scsi: scsi_debug: Maintain write statistics per group number Documentation/filesystems/f2fs.rst | 70 +++++++ block/bio.c | 2 + block/blk-crypto-fallback.c | 1 + block/blk-merge.c | 8 + block/blk-mq.c | 2 + block/bounce.c | 1 + block/fops.c | 14 ++ drivers/scsi/Kconfig | 5 + drivers/scsi/Makefile | 2 + drivers/scsi/scsi.c | 2 + drivers/scsi/scsi_debug.c | 293 ++++++++++++++++++++++------- drivers/scsi/scsi_proto_test.c | 56 ++++++ drivers/scsi/scsi_sysfs.c | 10 + drivers/scsi/sd.c | 111 ++++++++++- drivers/scsi/sd.h | 3 + fs/buffer.c | 12 +- fs/direct-io.c | 2 + fs/f2fs/data.c | 2 + fs/f2fs/f2fs.h | 10 + fs/f2fs/segment.c | 95 ++++++++++ fs/f2fs/super.c | 32 +++- fs/fcntl.c | 63 ++++--- fs/inode.c | 1 + fs/iomap/buffered-io.c | 2 + fs/iomap/direct-io.c | 1 + fs/mpage.c | 1 + include/linux/blk-mq.h | 2 + include/linux/blk_types.h | 2 + include/linux/fs.h | 17 +- include/linux/rw_hint.h | 21 +++ include/scsi/scsi_device.h | 1 + include/scsi/scsi_proto.h | 78 ++++++++ include/trace/events/f2fs.h | 6 +- 33 files changed, 813 insertions(+), 115 deletions(-) create mode 100644 drivers/scsi/scsi_proto_test.c create mode 100644 include/linux/rw_hint.h