| Message ID | 20240420084505.3624763-1-yukuai1@huaweicloud.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add new tests for blk-throttle | expand |
Hi, Tejun and Shinichiro And +CC Ming 在 2024/04/20 16:45, Yu Kuai 写道: > From: Yu Kuai <yukuai3@huawei.com> > > changes in v3: > - lots of style changes suggested by Shinichiro > > changes in v2: > - move lots of functions to rc > > Yu Kuai (5): > tests/throtl: add first test for blk-throttle > tests/throtl: add a new test 002 > tests/throtl: add a new test 003 > tests/throtl: add a new test 004 > tests/throtl: add a new test 005 Do you guys have any suggestions on these tests? Our clients report a problem that iops limit will cause IO hang, root cause is the same as [1], and this behaviour is introduced by commit 9f5ede3c01f9 ("block: throttle split bio in case of iops limit"), splited IO will be re throttled at the tail of bio list. And we're planing to fix this(Our clients don't accept this behaviour), by spliting bio-list into a bps throttled list and iops throttled list, so if iops is within limit, splited IO can be dispatched directly. And it'll be good to still have a place upstream for functional tests. [1] https://lore.kernel.org/all/20240812150049.8252-1-ioworker0@gmail.com/ Thanks, Kuai > > tests/throtl/001 | 39 ++++++++++++++++++ > tests/throtl/001.out | 6 +++ > tests/throtl/002 | 30 ++++++++++++++ > tests/throtl/002.out | 4 ++ > tests/throtl/003 | 32 +++++++++++++++ > tests/throtl/003.out | 4 ++ > tests/throtl/004 | 37 +++++++++++++++++ > tests/throtl/004.out | 4 ++ > tests/throtl/005 | 37 +++++++++++++++++ > tests/throtl/005.out | 3 ++ > tests/throtl/rc | 96 ++++++++++++++++++++++++++++++++++++++++++++ > 11 files changed, 292 insertions(+) > create mode 100755 tests/throtl/001 > create mode 100644 tests/throtl/001.out > create mode 100755 tests/throtl/002 > create mode 100644 tests/throtl/002.out > create mode 100755 tests/throtl/003 > create mode 100644 tests/throtl/003.out > create mode 100755 tests/throtl/004 > create mode 100644 tests/throtl/004.out > create mode 100755 tests/throtl/005 > create mode 100644 tests/throtl/005.out > create mode 100644 tests/throtl/rc >
On Oct 31, 2024 / 16:02, Yu Kuai wrote: > Hi, Tejun and Shinichiro > > And +CC Ming > > 在 2024/04/20 16:45, Yu Kuai 写道: > > From: Yu Kuai <yukuai3@huawei.com> > > > > changes in v3: > > - lots of style changes suggested by Shinichiro > > > > changes in v2: > > - move lots of functions to rc > > > > Yu Kuai (5): > > tests/throtl: add first test for blk-throttle > > tests/throtl: add a new test 002 > > tests/throtl: add a new test 003 > > tests/throtl: add a new test 004 > > tests/throtl: add a new test 005 > > Do you guys have any suggestions on these tests? Hi Yu, sorry, I totally overlooked this v3 series. It reflected all of my comments for v2 (thanks!) and looks good to me. I will wait some more days. If there is no objection (I do not expect any), I will apply them.
On Nov 01, 2024 / 10:50, Shinichiro Kawasaki wrote: > On Oct 31, 2024 / 16:02, Yu Kuai wrote: > > Hi, Tejun and Shinichiro > > > > And +CC Ming > > > > 在 2024/04/20 16:45, Yu Kuai 写道: > > > From: Yu Kuai <yukuai3@huawei.com> > > > > > > changes in v3: > > > - lots of style changes suggested by Shinichiro > > > > > > changes in v2: > > > - move lots of functions to rc > > > > > > Yu Kuai (5): > > > tests/throtl: add first test for blk-throttle > > > tests/throtl: add a new test 002 > > > tests/throtl: add a new test 003 > > > tests/throtl: add a new test 004 > > > tests/throtl: add a new test 005 > > > > Do you guys have any suggestions on these tests? > > Hi Yu, sorry, I totally overlooked this v3 series. It reflected all of my > comments for v2 (thanks!) and looks good to me. > > I will wait some more days. If there is no objection (I do not expect > any), I will apply them. I have applied the series. Thanks!
From: Yu Kuai <yukuai3@huawei.com> changes in v3: - lots of style changes suggested by Shinichiro changes in v2: - move lots of functions to rc Yu Kuai (5): tests/throtl: add first test for blk-throttle tests/throtl: add a new test 002 tests/throtl: add a new test 003 tests/throtl: add a new test 004 tests/throtl: add a new test 005 tests/throtl/001 | 39 ++++++++++++++++++ tests/throtl/001.out | 6 +++ tests/throtl/002 | 30 ++++++++++++++ tests/throtl/002.out | 4 ++ tests/throtl/003 | 32 +++++++++++++++ tests/throtl/003.out | 4 ++ tests/throtl/004 | 37 +++++++++++++++++ tests/throtl/004.out | 4 ++ tests/throtl/005 | 37 +++++++++++++++++ tests/throtl/005.out | 3 ++ tests/throtl/rc | 96 ++++++++++++++++++++++++++++++++++++++++++++ 11 files changed, 292 insertions(+) create mode 100755 tests/throtl/001 create mode 100644 tests/throtl/001.out create mode 100755 tests/throtl/002 create mode 100644 tests/throtl/002.out create mode 100755 tests/throtl/003 create mode 100644 tests/throtl/003.out create mode 100755 tests/throtl/004 create mode 100644 tests/throtl/004.out create mode 100755 tests/throtl/005 create mode 100644 tests/throtl/005.out create mode 100644 tests/throtl/rc