mbox series

[v6,0/3] Rust block device driver API and null block driver

Message ID 20240611114551.228679-1-nmi@metaspace.dk (mailing list archive)
Headers show
Series Rust block device driver API and null block driver | expand

Message

Andreas Hindborg June 11, 2024, 11:45 a.m. UTC 
From: Andreas Hindborg <a.hindborg@samsung.com>

Hi,

This series provides an initial Rust block layer device driver API, and a very
minimal null block driver to exercise the API. The driver has only one mode of
operation and cannot be configured.

These patches are an updated and trimmed down version of the v2 RFC [1]. One of
the requests for the v2 RFC was to split the abstractions into smaller pieces
that are easier to review. This is the first part of the split patches.

A notable change in this patch set is that they no longer use the `ref` field of
the C `struct request` to manage lifetime of the request structure.

The removed features will be sent later, as their dependencies land upstream.

Changes from v5 [2]:
 - update `SAFETY` comments of `Operations::queue_rq_callback`
 - update `SAFETY` comments of `Operations::init_request_callback`
 - update `SAFETY` comments of `Operations::exit_request_callback`
 - update `SAFETY` comments of `Request::wrapper_ptr`
 - change `Operations::init_request_callback` implementation to use `Request::wrapper_ptr`
 - rebased on v6.10-rc3

Thanks to everyone for comments on previous version!

Best regards,
Andreas Hindborg


Link: https://lore.kernel.org/all/20240313110515.70088-1-nmi@metaspace.dk/ [1]
Link: https://lore.kernel.org/all/20240603191455.968301-1-nmi@metaspace.dk/ [2]


Andreas Hindborg (3):
  rust: block: introduce `kernel::block::mq` module
  rust: block: add rnull, Rust null_blk implementation
  MAINTAINERS: add entry for Rust block device driver API

 MAINTAINERS                        |  14 ++
 drivers/block/Kconfig              |   9 +
 drivers/block/Makefile             |   3 +
 drivers/block/rnull.rs             |  73 +++++++++
 rust/bindings/bindings_helper.h    |   3 +
 rust/helpers.c                     |  16 ++
 rust/kernel/block.rs               |   5 +
 rust/kernel/block/mq.rs            |  98 +++++++++++
 rust/kernel/block/mq/gen_disk.rs   | 215 ++++++++++++++++++++++++
 rust/kernel/block/mq/operations.rs | 245 ++++++++++++++++++++++++++++
 rust/kernel/block/mq/raw_writer.rs |  55 +++++++
 rust/kernel/block/mq/request.rs    | 253 +++++++++++++++++++++++++++++
 rust/kernel/block/mq/tag_set.rs    |  86 ++++++++++
 rust/kernel/error.rs               |   6 +
 rust/kernel/lib.rs                 |   2 +
 15 files changed, 1083 insertions(+)
 create mode 100644 drivers/block/rnull.rs
 create mode 100644 rust/kernel/block.rs
 create mode 100644 rust/kernel/block/mq.rs
 create mode 100644 rust/kernel/block/mq/gen_disk.rs
 create mode 100644 rust/kernel/block/mq/operations.rs
 create mode 100644 rust/kernel/block/mq/raw_writer.rs
 create mode 100644 rust/kernel/block/mq/request.rs
 create mode 100644 rust/kernel/block/mq/tag_set.rs


base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670

Comments

Jens Axboe June 14, 2024, 1:45 p.m. UTC | #1 
On Tue, 11 Jun 2024 13:45:48 +0200, Andreas Hindborg wrote:
> This series provides an initial Rust block layer device driver API, and a very
> minimal null block driver to exercise the API. The driver has only one mode of
> operation and cannot be configured.
> 
> These patches are an updated and trimmed down version of the v2 RFC [1]. One of
> the requests for the v2 RFC was to split the abstractions into smaller pieces
> that are easier to review. This is the first part of the split patches.
> 
> [...]

Applied, thanks!

[1/3] rust: block: introduce `kernel::block::mq` module
      commit: 3253aba3408aa4eb2e4e09365eede3e63ef7536b
[2/3] rust: block: add rnull, Rust null_blk implementation
      commit: bc5b533b91ef0b8a09fe507e23d1c6c43c1fb0f5
[3/3] MAINTAINERS: add entry for Rust block device driver API
      commit: d37a9ab8331cfc0fc2eac0480f0af624c0144a92

Best regards,