[RFC,blktests,v2,00/03] Add support to run against real target

Message

Daniel Wagner June 12, 2024, 11:04 a.m. UTC

I've updated this series and added a simple example how to use it. I didn't
really know where to put it, so I added this part to new directorty called
'contrib'.

Don't know if we want to keep adding environment variables for this or if it
would be simpler to pass in a configuration file. The environemnt variable are
fairly simple to handle and it works. Adding a configuraiton file adds more code
to blktests.

changes:
v2:
  - many of the preperation patches have been merged, drop them
  - added a python script which implements the blktests API
  - add some documentation how to use it
  - changed the casing of the environment variables to upper case

v1:
  - initial version
  - https://lore.kernel.org/linux-nvme/[e-mail]/
  


Daniel Wagner (3):
  nvme/rc: introduce remote target support
  nvme/030: only run against kernel soft target
  contrib: add remote target setup/cleanup script

 Documentation/running-tests.md |   9 +++
 contrib/nvme_target_control.py | 110 +++++++++++++++++++++++++++++++++
 contrib/nvmet-subsys.jinja2    |  71 +++++++++++++++++++++
 tests/nvme/030                 |   1 +
 tests/nvme/rc                  |  56 +++++++++++++++--
 5 files changed, 243 insertions(+), 4 deletions(-)
 create mode 100755 contrib/nvme_target_control.py
 create mode 100644 contrib/nvmet-subsys.jinja2

Comments

Shin'ichiro Kawasaki June 14, 2024, 5:05 a.m. UTC | #1

Hi Daniel,

On Jun 12, 2024 / 13:04, Daniel Wagner wrote:
> I've updated this series and added a simple example how to use it. I didn't
> really know where to put it, so I added this part to new directorty called
> 'contrib'.

I'm fine with this. Some other helper scripts maybe go into the contrib
directory in the future.

> 
> Don't know if we want to keep adding environment variables for this or if it
> would be simpler to pass in a configuration file. The environemnt variable are
> fairly simple to handle and it works. Adding a configuraiton file adds more code
> to blktests.

The first patch added 4 new environemnt variables. Unless you plan to add more,
I think it's fine with the environemnt variable approach.

Overall, the changes do not affect core part of blktests. This looks good to me.

I'm not sure if the NVME_TARGET_CONTROL script command line interface will be
stable or not (setup/cleanup, --subsysnqn, --subsys-uuid and --hostnqn options).
I wonder the disucssion with Hannes may affect it.