[RFC,00/11] block debugfs: Catch missing flag array members

Message

John Garry July 9, 2024, 11:05 a.m. UTC

Currently we rely on the developer to add the appropriate entry to the
debugfs flag array when we add a new member.

This has shown to be error prone.

As an attempt to solve this problem, add compile-time assertions that we
are not missing flag array entries.

This should solve the problem that we don't miss entries, but we still
rely on the developer to add in the proper order.

Marking as an RFC as I am not sure if this is the best approach. And the
enum-related changes will require further work, I think.

Christoph Hellwig (1):
  block: remove QUEUE_FLAG_STOPPED

John Garry (10):
  block: Make QUEUE_FLAG_x as an enum
  block: Add build-time assert for size of blk_queue_flag_name[]
  block: Catch possible entries missing from hctx_state_name[]
  block: Catch possible entries missing from hctx_flag_name[]
  block: Catch possible entries missing from alloc_policy_name[]
  block: Add missing entries from cmd_flag_name[]
  block: Catch possible entries missing from cmd_flag_name[]
  block: Make RQF_x as an enum
  block: Add zone write plugging entry to rqf_name[]
  block: Catch possible entries missing from rqf_name[]

 block/blk-mq-debugfs.c    | 20 +++++++--
 include/linux/blk-mq.h    | 88 +++++++++++++++++++++++----------------
 include/linux/blk_types.h |  1 +
 include/linux/blkdev.h    | 31 +++++++-------
 4 files changed, 86 insertions(+), 54 deletions(-)