mbox series

[v4,0/3] nbd: WRITE_ZEROES and a few fixes

Message ID 20240812133032.115134-1-w@uter.be (mailing list archive)
Headers show
Series nbd: WRITE_ZEROES and a few fixes | expand

Message

Wouter Verhelst Aug. 12, 2024, 1:20 p.m. UTC 
Implement the WRITE_ZEROES command for the NBD kernel driver. While
here, add NBD_FLAG_ROTATIONAL to the function that decodes our flags for
debugfs.

---
v2: Divide UINT_MAX by blksize for the maximum number of sectors
supported by trim/discard and write_zeroes commands, as NBD uses 32-bit
values for byte lengths, and otherwise that wouldn't fit.
v3: Use the SECTOR_SHIFT value as a right-shift operand, rather than the
blksize value, to get the correct operand.
v4: Fix commit messages to use correct style. Thanks, Jens.
---
 drivers/block/nbd.c      |   12 +++++++++++-
 include/uapi/linux/nbd.h |    5 ++++-
 2 files changed, 15 insertions(+), 2 deletions(-)

Comments

Wouter Verhelst Sept. 5, 2024, 10 p.m. UTC | #1 
Hi Jens,

Has been a few weeks since I sent this. Friendly ping?

On Mon, Aug 12, 2024 at 03:20:35PM +0200, Wouter Verhelst wrote:
> Implement the WRITE_ZEROES command for the NBD kernel driver. While
> here, add NBD_FLAG_ROTATIONAL to the function that decodes our flags for
> debugfs.
> 
> ---
> v2: Divide UINT_MAX by blksize for the maximum number of sectors
> supported by trim/discard and write_zeroes commands, as NBD uses 32-bit
> values for byte lengths, and otherwise that wouldn't fit.
> v3: Use the SECTOR_SHIFT value as a right-shift operand, rather than the
> blksize value, to get the correct operand.
> v4: Fix commit messages to use correct style. Thanks, Jens.
> ---
>  drivers/block/nbd.c      |   12 +++++++++++-
>  include/uapi/linux/nbd.h |    5 ++++-
>  2 files changed, 15 insertions(+), 2 deletions(-)
> 
>
Jens Axboe Sept. 6, 2024, 2:31 p.m. UTC | #2 
On Mon, 12 Aug 2024 15:20:35 +0200, Wouter Verhelst wrote:
> Implement the WRITE_ZEROES command for the NBD kernel driver. While
> here, add NBD_FLAG_ROTATIONAL to the function that decodes our flags for
> debugfs.
> 

Applied, thanks!

[1/3] nbd: implement the WRITE_ZEROES command
      commit: e49dacc71ec2621ce4c422cd5605d4d06f7807b0
[2/3] nbd: nbd_bg_flags_show: add NBD_FLAG_ROTATIONAL
      commit: 41372f5c9a866365e212809b3543ae8cb5b2542b
[3/3] nbd: correct the maximum value for discard sectors
      commit: 296dbc72d29085d5fc34430d0760423071e9e81d

Best regards,