[V2,00/11] ublk: cleanup & improvement & zc follow-up

Message

Ming Lei March 27, 2025, 9:51 a.m. UTC

Hello Jens,

The 1st two fixes ublk_abort_requests(), and adds comment on handling
ubq->canceling.

The 3rd ~ 5th patches are cleanup.

The 6th and 7th are zc-followup.

The 8th & 9th patch implements ->queue_rqs() and improves IOPS by > 10%.

The last two patches are self-test for ->queue_rqs() & segment parameter
change.

V2:
	- use io_uring_cmd_to_pdu() (Uday)
	- improve zc document (Caleb)
	- consolidate segment parameter interface (Caleb)
	- add reviewed-by
	- add one fix and comment on ubq->canceling
	- fix one hang bug in V2


Ming Lei (11):
  ublk: make sure ubq->canceling is set when queue is frozen
  ublk: comment on ubq->canceling handling in ublk_queue_rq()
  ublk: remove two unused fields from 'struct ublk_queue'
  ublk: add helper of ublk_need_map_io()
  ublk: call io_uring_cmd_to_pdu to get uring_cmd pdu
  ublk: add segment parameter
  ublk: document zero copy feature
  ublk: implement ->queue_rqs()
  ublk: rename ublk_rq_task_work_cb as ublk_cmd_tw_cb
  selftests: ublk: add more tests for covering MQ
  selftests: ublk: add test for checking zero copy related parameter

 Documentation/block/ublk.rst                  |  35 ++-
 drivers/block/ublk_drv.c                      | 214 ++++++++++++++----
 include/uapi/linux/ublk_cmd.h                 |  25 ++
 tools/testing/selftests/ublk/Makefile         |   4 +
 tools/testing/selftests/ublk/null.c           |  11 +-
 tools/testing/selftests/ublk/test_common.sh   |   6 +
 .../testing/selftests/ublk/test_generic_02.sh |  44 ++++
 .../testing/selftests/ublk/test_generic_03.sh |  28 +++
 tools/testing/selftests/ublk/test_loop_01.sh  |  14 +-
 tools/testing/selftests/ublk/test_loop_03.sh  |  14 +-
 tools/testing/selftests/ublk/test_loop_05.sh  |  28 +++
 .../testing/selftests/ublk/test_stress_01.sh  |   6 +-
 .../testing/selftests/ublk/test_stress_02.sh  |   6 +-
 .../testing/selftests/ublk/test_stripe_01.sh  |  14 +-
 .../testing/selftests/ublk/test_stripe_03.sh  |  30 +++
 15 files changed, 397 insertions(+), 82 deletions(-)
 create mode 100755 tools/testing/selftests/ublk/test_generic_02.sh
 create mode 100755 tools/testing/selftests/ublk/test_generic_03.sh
 create mode 100755 tools/testing/selftests/ublk/test_loop_05.sh
 create mode 100755 tools/testing/selftests/ublk/test_stripe_03.sh

Comments

Jens Axboe March 28, 2025, 1:58 p.m. UTC | #1

On Thu, 27 Mar 2025 17:51:09 +0800, Ming Lei wrote:
> The 1st two fixes ublk_abort_requests(), and adds comment on handling
> ubq->canceling.
> 
> The 3rd ~ 5th patches are cleanup.
> 
> The 6th and 7th are zc-followup.
> 
> [...]

Applied, thanks!

[01/11] ublk: make sure ubq->canceling is set when queue is frozen
        commit: 9c397ab202da574da65be6f4901d6260ad28d420
[02/11] ublk: comment on ubq->canceling handling in ublk_queue_rq()
        commit: 2563451efc04e6e32b089696d221498277b5addb
[03/11] ublk: remove two unused fields from 'struct ublk_queue'
        commit: b4ce4eae5c0e3afcdf4a1fb8c85e5c171a2ea5db
[04/11] ublk: add helper of ublk_need_map_io()
        commit: 8a799a1616dd34724d9283ca0c4b96003da53d6a
[05/11] ublk: call io_uring_cmd_to_pdu to get uring_cmd pdu
        commit: 639cf001d7cca2bdaccff3f545d80394b6b36a53
[06/11] ublk: add segment parameter
        commit: e14e391fc9cc38a54f7528077930eae4f573b58e
[07/11] ublk: document zero copy feature
        commit: 9f7862ebfb05db6ce88f6eeb0e6144cda284cdc2
[08/11] ublk: implement ->queue_rqs()
        commit: d7aad08075f13bd9eb9cc73df831278f6c843aa4
[09/11] ublk: rename ublk_rq_task_work_cb as ublk_cmd_tw_cb
        commit: 48c74741b43f77e7fef74f2ad2bb714bdf1675e1
[10/11] selftests: ublk: add more tests for covering MQ
        commit: 7e1121b53e27978c5e33f241e87f4ffee45febd9
[11/11] selftests: ublk: add test for checking zero copy related parameter
        commit: 888ba37f212022926462d7d0b993ee5354a30907

Best regards,