[v2,0/3] Inline sqe_submit

Message

Pavel Begunkov Nov. 6, 2019, 10 p.m. UTC

The idea is to not pass struct sqe_submit as a separate entity,
but always use req->submit instead, so there will be less stuff to
care about.

Also, I've got steady +1% throughput improvement for nop tests.
Though, it's highly system-dependent, and I wouldn't count on it.

v2: fix use-after-free catched by Jens


Pavel Begunkov (3):
  io_uring: allocate io_kiocb upfront
  io_uring: Use submit info inlined into req
  io_uring: use inlined struct sqe_submit

 fs/io_uring.c | 132 +++++++++++++++++++++++++-------------------------
 1 file changed, 65 insertions(+), 67 deletions(-)

Comments

Pavel Begunkov Nov. 6, 2019, 10:10 p.m. UTC | #1

On 07/11/2019 01:00, Pavel Begunkov wrote:
> The idea is to not pass struct sqe_submit as a separate entity,
> but always use req->submit instead, so there will be less stuff to
> care about.
> 

Hope, I didn't missed anything here. In the meantime I'll run
tests and will let you know when it's done.


> Also, I've got steady +1% throughput improvement for nop tests.
> Though, it's highly system-dependent, and I wouldn't count on it.
> 
> v2: fix use-after-free catched by Jens
> 
> 
> Pavel Begunkov (3):
>   io_uring: allocate io_kiocb upfront
>   io_uring: Use submit info inlined into req
>   io_uring: use inlined struct sqe_submit
> 
>  fs/io_uring.c | 132 +++++++++++++++++++++++++-------------------------
>  1 file changed, 65 insertions(+), 67 deletions(-)
>