From patchwork Wed May 15 13:27:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikulas Patocka X-Patchwork-Id: 13665270 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A8DD3BB4D for ; Wed, 15 May 2024 13:27:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715779656; cv=none; b=YkQxxxFtWnmViwNyAVE83cCBDOk1ZlrsPWkOW3bo1TWBGBnBddzThw5mPMpkjchsoFdkqd2Fnj7PhmDloNER5bpqTwU7fbC/SC0pLUcvOBFf5RWPwxmwdA8OZCIjGFRPls/t6mUh7wCVcXsHZNzjMts0BVV3bgjMldy6XOZc06E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715779656; c=relaxed/simple; bh=7NN+p0VArzGwk72h7bf9onqlo8hFDngBzL8RjKLPj/s=; h=Date:From:To:cc:Subject:Message-ID:MIME-Version:Content-Type; b=ibWDMu1P1AOrUpyyLML5llwoeX3Pyj4pldGZs/onv26jnq5a9N6FKSQ3c4n3fWnbNb33jSmmuOn/Q3rjqO7BEP+RCSsTaGYBhEWZJBWndLTMbacy9jQEydapMnqSPUZHzJ45lf0kZkUcS65ZwleBCE0VjDtcE76ujtc8RNPolug= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TZrm+h/M; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TZrm+h/M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715779653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=g5fc8mcPKMWKuhRC4H98ePL+lLJSZdpFd80L6MUtTVs=; b=TZrm+h/MlmSz0UJ062UvdLT7rj91CthXdg0JDlV33gqZebpDmnGOhftqHwvs7KU0oHvEim Vfp2hzhTf2u7U0y7LBS6qQz1V+GUJWzC0e52+6QemLKHO9IEjoZczyoIR7/jxkn1i+OT0Y mEH1xa1CUobr0rhCnBg5QjvxFc3atOk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-_pFjeoFPPYGUAvQmLQ8GsQ-1; Wed, 15 May 2024 09:27:27 -0400 X-MC-Unique: _pFjeoFPPYGUAvQmLQ8GsQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 36A918058C8; Wed, 15 May 2024 13:27:27 +0000 (UTC) Received: from file1-rdu.file-001.prod.rdu2.dc.redhat.com (unknown [10.11.5.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E8D281C008BB; Wed, 15 May 2024 13:27:26 +0000 (UTC) Received: by file1-rdu.file-001.prod.rdu2.dc.redhat.com (Postfix, from userid 12668) id D068D30C7280; Wed, 15 May 2024 13:27:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by file1-rdu.file-001.prod.rdu2.dc.redhat.com (Postfix) with ESMTP id CECAF3FB52; Wed, 15 May 2024 15:27:26 +0200 (CEST) Date: Wed, 15 May 2024 15:27:26 +0200 (CEST) From: Mikulas Patocka To: Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , Mike Snitzer , Milan Broz cc: linux-block@vger.kernel.org, dm-devel@lists.linux.dev, linux-nvme@lists.infradead.org Subject: [RFC PATCH 0/2] dm-crypt support for per-sector NVMe metadata Message-ID: Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Hi Some NVMe devices may be formatted with extra 64 bytes of metadata per sector. Here I'm submitting for review dm-crypt patches that make it possible to use per-sector metadata for authenticated encryption. With these patches, dm-crypt can run directly on the top of a NVMe device, without using dm-integrity. These patches increase write throughput twice, because there is no write to the dm-integrity journal. An example how to use it (so far, there is no support in the userspace cryptsetup tool): # nvme format /dev/nvme1 -n 1 -lbaf=4 # dmsetup create cr --table '0 1048576 crypt capi:authenc(hmac(sha256),cbc(aes))-essiv:sha256 01b11af6b55f76424fd53fb66667c301466b2eeaf0f39fd36d26e7fc4f52ade2de4228e996f5ae2fe817ce178e77079d28e4baaebffbcd3e16ae4f36ef217298 0 /dev/nvme1n1 0 2 integrity:32:aead sector_size:4096' Please review it - I'd like to know whether detecting the presence of per-sector metadata in crypt_integrity_ctr is correct whether it should be done differently. Mikulas