| Message ID | 06a7b6da-f3de-43cb-8ac5-bdd090a7d33b@kernel.dk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block/iocost: silence warning on 'last_period' potentially being unused | expand |
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On Wed, Jan 10, 2024 at 08:32:19AM -0700, Jens Axboe wrote: > If CONFIG_TRACEPOINTS isn't enabled, we assign this variable but then > never use it. This can cause the compiler to complain about that: > > block/blk-iocost.c:1264:6: warning: variable 'last_period' set but not used [-Wunused-but-set-variable] > 1264 | u64 last_period, cur_period; > | ^ > > Rather than add ifdefs to guard this, just mark it __maybe_unused. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202401102335.GiWdeIo9-lkp@intel.com/ > Signed-off-by: Jens Axboe <axboe@kernel.dk> Acked-by: Tejun Heo <tj@kernel.org> Thanks.
On 1/10/2024 7:32 AM, Jens Axboe wrote: > If CONFIG_TRACEPOINTS isn't enabled, we assign this variable but then > never use it. This can cause the compiler to complain about that: > > block/blk-iocost.c:1264:6: warning: variable 'last_period' set but not used [-Wunused-but-set-variable] > 1264 | u64 last_period, cur_period; > | ^ > > Rather than add ifdefs to guard this, just mark it __maybe_unused. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202401102335.GiWdeIo9-lkp@intel.com/ > Signed-off-by: Jens Axboe <axboe@kernel.dk> > > --- > much cleaner than ifdef for sure... Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> -ck
diff --git a/block/blk-iocost.c b/block/blk-iocost.c index 089fcb9cfce3..c8beec6d7df0 100644 --- a/block/blk-iocost.c +++ b/block/blk-iocost.c @@ -1261,7 +1261,7 @@ static void weight_updated(struct ioc_gq *iocg, struct ioc_now *now) static bool iocg_activate(struct ioc_gq *iocg, struct ioc_now *now) { struct ioc *ioc = iocg->ioc; - u64 last_period, cur_period; + u64 __maybe_unused last_period, cur_period; u64 vtime, vtarget; int i;
If CONFIG_TRACEPOINTS isn't enabled, we assign this variable but then never use it. This can cause the compiler to complain about that: block/blk-iocost.c:1264:6: warning: variable 'last_period' set but not used [-Wunused-but-set-variable] 1264 | u64 last_period, cur_period; | ^ Rather than add ifdefs to guard this, just mark it __maybe_unused. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401102335.GiWdeIo9-lkp@intel.com/ Signed-off-by: Jens Axboe <axboe@kernel.dk> ---