| Message ID | 0ef6e852-9c76-ce74-6f21-c0398722c9e5@users.sourceforge.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01/16/2018 10:10 PM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 16 Jan 2018 22:00:15 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/lightnvm/pblk-gc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c > index 9c8e114c8a54..54cdb4360366 100644 > --- a/drivers/lightnvm/pblk-gc.c > +++ b/drivers/lightnvm/pblk-gc.c > @@ -147,10 +147,8 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work) > int ret; > > invalid_bitmap = kmalloc(lm->sec_bitmap_len, GFP_KERNEL); > - if (!invalid_bitmap) { > - pr_err("pblk: could not allocate GC invalid bitmap\n"); > + if (!invalid_bitmap) > goto fail_free_ws; > - } > > emeta_buf = pblk_malloc(lm->emeta_len[0], l_mg->emeta_alloc_type, > GFP_KERNEL); > Thanks Markus. I'll queue it up for 4.17.
> On 16 Jan 2018, at 22.10, SF Markus Elfring <elfring@users.sourceforge.net> wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 16 Jan 2018 22:00:15 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/lightnvm/pblk-gc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c > index 9c8e114c8a54..54cdb4360366 100644 > --- a/drivers/lightnvm/pblk-gc.c > +++ b/drivers/lightnvm/pblk-gc.c > @@ -147,10 +147,8 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work) > int ret; > > invalid_bitmap = kmalloc(lm->sec_bitmap_len, GFP_KERNEL); > - if (!invalid_bitmap) { > - pr_err("pblk: could not allocate GC invalid bitmap\n"); > + if (!invalid_bitmap) > goto fail_free_ws; > - } > > emeta_buf = pblk_malloc(lm->emeta_len[0], l_mg->emeta_alloc_type, > GFP_KERNEL); > -- > 2.15.1 Looks good to me. Reviewed-by: Javier González <javier@cnexlabs.com>
diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c index 9c8e114c8a54..54cdb4360366 100644 --- a/drivers/lightnvm/pblk-gc.c +++ b/drivers/lightnvm/pblk-gc.c @@ -147,10 +147,8 @@ static void pblk_gc_line_prepare_ws(struct work_struct *work) int ret; invalid_bitmap = kmalloc(lm->sec_bitmap_len, GFP_KERNEL); - if (!invalid_bitmap) { - pr_err("pblk: could not allocate GC invalid bitmap\n"); + if (!invalid_bitmap) goto fail_free_ws; - } emeta_buf = pblk_malloc(lm->emeta_len[0], l_mg->emeta_alloc_type, GFP_KERNEL);