From patchwork Mon Nov 16 14:34:47 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Matias_Bj=C3=B8rling?= X-Patchwork-Id: 7627851 X-Patchwork-Delegate: axboe@kernel.dk Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 18E279F2EC for ; Mon, 16 Nov 2015 14:38:47 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1F82120588 for ; Mon, 16 Nov 2015 14:38:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EB4320569 for ; Mon, 16 Nov 2015 14:38:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbbKPOid (ORCPT ); Mon, 16 Nov 2015 09:38:33 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:34711 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752322AbbKPOhm (ORCPT ); Mon, 16 Nov 2015 09:37:42 -0500 Received: by wmvv187 with SMTP id v187so179681605wmv.1 for ; Mon, 16 Nov 2015 06:37:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bjorling.me; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=SdcmoMkwbUnr9Apz6jvHbWg0InBjvR5Krqe9ywmBPyE=; b=AhXfiDLQRBPjNMd4Gcw/ylYWsWmisso6mupKCbMKRhpQSqLz/IqOfYLtKs0xYO0FsE YjEHw+vAK+rYkEGZJn8toFm2ZYF25p49Z7AXDlNo5nT9GIYybonmkkimgm0TdIqRVh5p L4QbQdbDKq5FQV7FN/HSYq1Ix5PmQ4oUeFrvI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=SdcmoMkwbUnr9Apz6jvHbWg0InBjvR5Krqe9ywmBPyE=; b=PQLmzDCPxd+GbVyoC3JcSsRP801+lOY8XFkH3NVTKiPpg+eo2MPYO6WqcGdwyazBjO 1iw1PrqcPlXXnu5Hd4rO33YtoxpW0IJrAKkc5acUziO3q0CWZ6xPkMnP25PCwXobqVEe tjMbMCagOjrpah8jWIWwcrlfNzFJmGg1jMxOYPF4R3wmoMCjC6HagyUuwK0VuZTayn1b 1RZhAo2SZZcsToUvZaId3gBxIH6DdqUQkVgH7gTuoWJVqFz8kLPLjdDaQXrjNCik4JMq VRSKxSlDLKmPimMsyh45tfVm9lQ/7BVOSGftYDmcx+nH6iEp9AF9nG3cp5QVwATsIkn1 w4fg== X-Gm-Message-State: ALoCoQkBLUyqqV46cDTjJuXiRx6yDpL9QfobWlidJhpCE3VReTKJJRE0OLKYDTiqMzW2e6Foy2Ol X-Received: by 10.28.32.65 with SMTP id g62mr18405601wmg.81.1447684660972; Mon, 16 Nov 2015 06:37:40 -0800 (PST) Received: from localhost.localdomain (6164198-cl69.boa.fiberby.dk. [193.106.164.198]) by smtp.gmail.com with ESMTPSA id u139sm18818127wmu.22.2015.11.16.06.37.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 16 Nov 2015 06:37:40 -0800 (PST) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, axboe@fb.com Cc: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= , Javier Gonzalez , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 13/13] lightnvm: cleanup queue before target removal Date: Mon, 16 Nov 2015 15:34:47 +0100 Message-Id: <1447684487-25539-14-git-send-email-m@bjorling.me> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1447684487-25539-1-git-send-email-m@bjorling.me> References: <1447684487-25539-1-git-send-email-m@bjorling.me> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Javier González This prevents outstanding IOs to be sent for completion to target after the target has been removed. The flow is now: stop new IOs > cleanup queue > remove target. Signed-off-by: Javier Gonzalez Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index 790b1d7..8a556f3 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -460,11 +460,11 @@ static void nvm_remove_target(struct nvm_target *t) lockdep_assert_held(&nvm_lock); del_gendisk(tdisk); + blk_cleanup_queue(q); + if (tt->exit) tt->exit(tdisk->private_data); - blk_cleanup_queue(q); - put_disk(tdisk); list_del(&t->list);