From patchwork Mon Nov 16 14:34:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Matias_Bj=C3=B8rling?= X-Patchwork-Id: 7628041 X-Patchwork-Delegate: axboe@kernel.dk Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id A6373BF90C for ; Mon, 16 Nov 2015 14:42:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CB56C2057E for ; Mon, 16 Nov 2015 14:42:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F05CA20459 for ; Mon, 16 Nov 2015 14:42:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752924AbbKPOmW (ORCPT ); Mon, 16 Nov 2015 09:42:22 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:33304 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543AbbKPOh2 (ORCPT ); Mon, 16 Nov 2015 09:37:28 -0500 Received: by wmec201 with SMTP id c201so179700607wme.0 for ; Mon, 16 Nov 2015 06:37:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bjorling.me; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=HuqEn0py5/oBLCai4e6eVvOeHww9Xw1jXSr9nnOiwRQ=; b=lH1YDtpRndpSY0UnUpv7rV0I24lkONBam1bbu+019DXVdNBOsOMZug1hh9mLVsHznn T9NDRaM0z9C7E3bOV57Bdwtc1MyL3lkBjwu2gcJylwOIB3Ihl34WqQYBGiIE124xW3Qb 78jS+GzG4xUaZMCjpfY6gGhVla7J8mzKX9H+g= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=HuqEn0py5/oBLCai4e6eVvOeHww9Xw1jXSr9nnOiwRQ=; b=c2xzap/cTZnrXoXajUNnBnQ98N+PEUFqCkJvbCBBlrgDvbrf3wkmR+bS8j6DLQle77 iBEdHgJYttm/CwbYQkfNHhADtxuMTpJK0/gScCKbUeFcLZ/XnXadfnMA9mOHCZJUaEe5 /kIqLynoaJY4nUYlXtulyHMVRptvXwOzgoDYUWLwo+lNzUyPb00RjTgEwAT6EPM4vdcD Fyev1qK82Xu88G+FLKI4GJPtQTU8TFZeg1eEaqU4mMPsMY5SHGpaI7znxFkYhisWeGWd cPVPoZmUTXpBqWTNFlTMIeceY2tkD3hlz+OJqUR/3xy6deACcD5mIGSco6fFqhrsCyu4 qElw== X-Gm-Message-State: ALoCoQnynFHU0iJjaez0VYGtKiFE9Ex7nqWerl6EItwNCQk3TPBkVflge9t+1NOICuPY1cf9wJv6 X-Received: by 10.28.194.84 with SMTP id s81mr16803938wmf.51.1447684647057; Mon, 16 Nov 2015 06:37:27 -0800 (PST) Received: from localhost.localdomain (6164198-cl69.boa.fiberby.dk. [193.106.164.198]) by smtp.gmail.com with ESMTPSA id u139sm18818127wmu.22.2015.11.16.06.37.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 16 Nov 2015 06:37:26 -0800 (PST) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, axboe@fb.com Cc: =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 02/13] lightnvm: change max_phys_sect to uint Date: Mon, 16 Nov 2015 15:34:36 +0100 Message-Id: <1447684487-25539-3-git-send-email-m@bjorling.me> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1447684487-25539-1-git-send-email-m@bjorling.me> References: <1447684487-25539-1-git-send-email-m@bjorling.me> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The max_phys_sect variable is defined as a char. We do a boundary check to maximally allow 256 physical page descriptors per command. As we are not indexing from zero. This expression is always false. Bump the max_phys_sect to an unsigned int to support the range check. Signed-off-by: Matias Bjørling Reported-by: Geert Uytterhoeven --- include/linux/lightnvm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h index 69c9057..32b5369 100644 --- a/include/linux/lightnvm.h +++ b/include/linux/lightnvm.h @@ -220,7 +220,7 @@ struct nvm_dev_ops { nvm_dev_dma_alloc_fn *dev_dma_alloc; nvm_dev_dma_free_fn *dev_dma_free; - uint8_t max_phys_sect; + unsigned int max_phys_sect; }; struct nvm_lun {