From patchwork Fri Nov 20 12:47:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Matias_Bj=C3=B8rling?= X-Patchwork-Id: 7667551 X-Patchwork-Delegate: axboe@kernel.dk Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CC885BF90C for ; Fri, 20 Nov 2015 12:48:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 12A8C2041A for ; Fri, 20 Nov 2015 12:48:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 351DB20411 for ; Fri, 20 Nov 2015 12:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162719AbbKTMsH (ORCPT ); Fri, 20 Nov 2015 07:48:07 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:34633 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760154AbbKTMsF (ORCPT ); Fri, 20 Nov 2015 07:48:05 -0500 Received: by wmvv187 with SMTP id v187so70422766wmv.1 for ; Fri, 20 Nov 2015 04:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bjorling.me; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=/EV3GkwW6NELh/0l7GtAG6vsKTT97Yr6ztkRnfbYZ4A=; b=vUJAIsIZmx7ozu4+PHXeun4YRxgA7JK6ykIIQmAzb6px1Br/hDB5LoXLGOwhJ+kkJ3 iGASM5qrgldhE8XlZ5+pxHJDzW/L4mPIlKDNYPbHjBHeMVogErbj0/iXIxdSTrs4ArgZ QTDUzVTvWGq2mffg5sKDjlImwhWDDvzE/MBZ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=/EV3GkwW6NELh/0l7GtAG6vsKTT97Yr6ztkRnfbYZ4A=; b=J6TabN99YuQyxS6EwYClGOw7t4ZKXn7XjWYKNvXaetrHoFcrOu7a4dF/LEnwKzWIAk zNJBrzx0y9fWU0j/u1y0fCYkBF9eUDVEc5nVWtSXrToNRSn9lRnn/N3WIPDvF+FkCswM Hj9a5PqLD2ztX+k7KC0tFkNalV1DhorDE6aQ6Sgrx7FYTBPZYycBe/zrilnARjzw+5LC 8YEZgUKjE96Smz0yT0KgBqRpo9VGgKoUj6yrlCFDwxIDDsmqVHjYy8CYLWz2tCG4zQIt DL7qmIfrTMy7HmLiQowYhYxkLHP4qaBEDT+fG+z5RR/Tu3Tig0P8iFxqMsaxcpPnNkG9 44pA== X-Gm-Message-State: ALoCoQmBeHvKeCJ7EHRLu/o1tm5R/U54Zrof23zWGIqVlqbSApTNS6Q3rcqWa8y1YTaXYoTloB9U X-Received: by 10.194.58.142 with SMTP id r14mr16636356wjq.37.1448023684653; Fri, 20 Nov 2015 04:48:04 -0800 (PST) Received: from localhost.localdomain (6164198-cl69.boa.fiberby.dk. [193.106.164.198]) by smtp.gmail.com with ESMTPSA id bh5sm12522435wjb.42.2015.11.20.04.48.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 20 Nov 2015 04:48:04 -0800 (PST) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@fb.com Cc: =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 2/5] lightnvm: missing free on init error Date: Fri, 20 Nov 2015 13:47:54 +0100 Message-Id: <1448023677-22296-3-git-send-email-m@bjorling.me> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1448023677-22296-1-git-send-email-m@bjorling.me> References: <1448023677-22296-1-git-send-email-m@bjorling.me> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-7.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If either max_phys_sect is out of bound, the nvm_dev structure is not freed. Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index bed47e7..f61d325 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -313,11 +313,13 @@ int nvm_register(struct request_queue *q, char *disk_name, "ppalist"); if (!dev->ppalist_pool) { pr_err("nvm: could not create ppa pool\n"); - return -ENOMEM; + ret = -ENOMEM; + goto err_init; } } else if (dev->ops->max_phys_sect > 256) { pr_info("nvm: max sectors supported is 256.\n"); - return -EINVAL; + ret = -EINVAL; + goto err_init; } down_write(&nvm_lock);