From patchwork Wed Dec 2 12:16:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Matias_Bj=C3=B8rling?= X-Patchwork-Id: 7745521 Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4E7939F350 for ; Wed, 2 Dec 2015 12:17:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5399820631 for ; Wed, 2 Dec 2015 12:17:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B06A205B7 for ; Wed, 2 Dec 2015 12:17:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755593AbbLBMQz (ORCPT ); Wed, 2 Dec 2015 07:16:55 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:38709 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755527AbbLBMQx (ORCPT ); Wed, 2 Dec 2015 07:16:53 -0500 Received: by wmec201 with SMTP id c201so55243412wme.1 for ; Wed, 02 Dec 2015 04:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bjorling.me; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; bh=4Ahf37Bhx/xsf9h0M9gkPzXXvwHkfwDM1xMyWr946fk=; b=EjJtG10yhSis6yHZVxjVyxS/4yLa/N/Y4M1S9JLmbYNqj7n1st6SLT/2viep9S/rZ8 3sDcAUk9x1MnO7Fzyx0ACSSuW8JOu2MVaiQs0c3w7cf5L3JUAqi9Ds3xvwTH/RAtdRJJ PKn5A6TJWban57rOIvjhYtESd1D4SJlGKdP0s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=4Ahf37Bhx/xsf9h0M9gkPzXXvwHkfwDM1xMyWr946fk=; b=HGzpSxNPyUZOTvsM+cH+fiQiKNdK4XJs2B4enkAv2wf2Cc1yrBdfloz8JDIKVYQy2M YC7cZvaLRuBmT96e5KoUG5m5FiPeafkISgf+7DuqfvRkq/aWhsXfgB4VhORO8w3NTWF4 9i4FTQEaA7jSdtm3DTGG8uITnQE1rrYcyMxNKgGWGY1WgpyzRAES9DyQU7jmybvvT0WE alReLTideezATBCDmObPGSpah655fq9IcD9nCT91gEWsV9omBQ0ht5QQb7/tuBNKAPm5 WVN+3it31yAzAwSyMCtMA28QDawldNlXOV9li5jd4wXGhdv0iBCOrHNAeideuLdFo9H8 XJYw== X-Gm-Message-State: ALoCoQkOjBmiYaVOKGGjr0lNSHnocYxsCPleC6DzJlrulW/KXaOC0TEhYtnmWLhw0IMeuQTI1zWD X-Received: by 10.28.97.197 with SMTP id v188mr5615672wmb.63.1449058611950; Wed, 02 Dec 2015 04:16:51 -0800 (PST) Received: from localhost.localdomain (6164198-cl69.boa.fiberby.dk. [193.106.164.198]) by smtp.gmail.com with ESMTPSA id q9sm2556213wjo.9.2015.12.02.04.16.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Dec 2015 04:16:51 -0800 (PST) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH RFC 2/3] lightnvm: comments on constants Date: Wed, 2 Dec 2015 13:16:22 +0100 Message-Id: <1449058583-27940-2-git-send-email-m@bjorling.me> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1449058583-27940-1-git-send-email-m@bjorling.me> References: <1449058583-27940-1-git-send-email-m@bjorling.me> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It is not obvious what NVM_IO_* and NVM_BLK_T_* is used for. Make sure to comment them appropriately as the other constants. Signed-off-by: Matias Bjørling --- include/linux/lightnvm.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h index c6916ae..935ef38 100644 --- a/include/linux/lightnvm.h +++ b/include/linux/lightnvm.h @@ -50,9 +50,16 @@ enum { NVM_IO_DUAL_ACCESS = 0x1, NVM_IO_QUAD_ACCESS = 0x2, + /* NAND Access Modes */ NVM_IO_SUSPEND = 0x80, NVM_IO_SLC_MODE = 0x100, NVM_IO_SCRAMBLE_DISABLE = 0x200, + + /* Block Types */ + NVM_BLK_T_FREE = 0x0, + NVM_BLK_T_BAD = 0x1, + NVM_BLK_T_DEV = 0x2, + NVM_BLK_T_HOST = 0x4, }; struct nvm_id_group {