From patchwork Tue Apr 5 12:07:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ming Lei X-Patchwork-Id: 8750891 Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 15CF7C0553 for ; Tue, 5 Apr 2016 12:11:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 498B52012B for ; Tue, 5 Apr 2016 12:11:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65BCE20117 for ; Tue, 5 Apr 2016 12:11:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932783AbcDEMKU (ORCPT ); Tue, 5 Apr 2016 08:10:20 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34039 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932575AbcDEMKQ (ORCPT ); Tue, 5 Apr 2016 08:10:16 -0400 Received: by mail-pf0-f196.google.com with SMTP id d184so1194491pfc.1; Tue, 05 Apr 2016 05:10:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=v2kZs1b4KTp7d6h2W3qVbNygacA5aGwkcWJ9r5e01Oc=; b=NsTKfB05tSqNRPXyyR1sb5221mjpJ0yoCa5NjtQlpA509LFpp56bULaATSsybYQk5N ZJ0KB67vtb6D5si9ln8l168GLsVZuFIjkrYvCfM6W/1E2GGOh5kUJLuU4UhRLlV2kj3q IngEPfI0eTEW/vRe80XK6MPnrDjNTZRYf4XaMg5e4/xm3aq+LD+Ikqx/BqX5hqRVyToa Ud5KgmiMUfbO2Pyn2sOG6kjpHGlnzrEhMGdktuu9MuwghLEq2JJsX4/BnzdrzPLXL5Lf Zg2jVru7lTSs7CSFAlSktr+xdf+a8Pu0ENhzqdLtWtYm5vWSUTHLORXJ2RPOQ4MzZPJn JZ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=v2kZs1b4KTp7d6h2W3qVbNygacA5aGwkcWJ9r5e01Oc=; b=hI0FsGoxOS9YcVAA3KKe27otAT0G5iOelyKb0zipb+dOP3CosqaGP5k36gz0b5lGgI 94oVT2SEXoGAKd1VlWENzEfS0vOenBwCBKH6XixvHtGdEVDkfVumFY0tudQx7hfHc3R6 Mkozo1EjDC0lnGx2jEe3l+Q5hIRmNLysMrZ38GEqUHf3IMF0XS/NS8t77pzdhIzrI/jF YZqOmZjNJr6EAZTyQamHtFOs1IiFAWit7NncWCZkRQA/gEf4obGan8wqs5+L/dBcmnbH CbNHdD91bDOs7huUvcOF1z13VpxAXGb4ZjUfdqhJRkKfQHuNmnX4Ii9D/YoCGJFQ43Fh oNmw== X-Gm-Message-State: AD7BkJLLNqtmp4BUbmqxYu5oYCK+G3afipO7GWFXr2k4SfH2cXIfWQPQG6HQ0bqPsSCosQ== X-Received: by 10.98.80.78 with SMTP id e75mr29400974pfb.147.1459858216024; Tue, 05 Apr 2016 05:10:16 -0700 (PDT) Received: from localhost (56.34.213.162.lcy-01.canonistack.canonical.com. [162.213.34.56]) by smtp.gmail.com with ESMTPSA id n11sm46558471pfb.74.2016.04.05.05.10.12 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 05 Apr 2016 05:10:15 -0700 (PDT) From: Ming Lei To: Jens Axboe , linux-kernel@vger.kernel.org Cc: linux-block@vger.kernel.org, Christoph Hellwig , Boaz Harrosh , Ming Lei , Joern Engel , Prasad Joshi , logfs@logfs.org (open list:LogFS) Subject: [PATCH 25/27] fs: logfs: remove unnecesary check Date: Tue, 5 Apr 2016 20:07:40 +0800 Message-Id: <1459858062-21075-11-git-send-email-tom.leiming@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459858062-21075-1-git-send-email-tom.leiming@gmail.com> References: <1459858062-21075-1-git-send-email-tom.leiming@gmail.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The check on bio->bi_vcnt doesn't make sense in erase_end_io(). Signed-off-by: Ming Lei --- fs/logfs/dev_bdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c index db04231..3d9cde7 100644 --- a/fs/logfs/dev_bdev.c +++ b/fs/logfs/dev_bdev.c @@ -144,7 +144,6 @@ static void erase_end_io(struct bio *bio) struct logfs_super *super = logfs_super(sb); BUG_ON(bio->bi_error); /* FIXME: Retry io or write elsewhere */ - BUG_ON(bio->bi_vcnt == 0); bio_put(bio); if (atomic_dec_and_test(&super->s_pending_writes)) wake_up(&wq);