| Message ID | 1459868131-15133-2-git-send-email-m@bjorling.me (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016-04-05 16:55, Matias Bjørling wrote: > The device ->submit_io() callback might fail to submit I/O to device. > In that case, the nvm_submit_ppa function should not wait for > completion. Instead return the ->submit_io() error. > > Signed-off-by: Matias Bjørling <m@bjorling.me> > --- > drivers/lightnvm/core.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c > index 0dc9a80..c2ef53a 100644 > --- a/drivers/lightnvm/core.c > +++ b/drivers/lightnvm/core.c > @@ -351,6 +351,11 @@ int nvm_submit_ppa(struct nvm_dev *dev, struct > ppa_addr *ppa, int nr_ppas, > nvm_generic_to_addr_mode(dev, &rqd); > > ret = dev->ops->submit_io(dev, &rqd); > + if (ret) { > + nvm_free_rqd_ppalist(dev, &rqd); > + bio_put(bio); > + return ret; > + } > > /* Prevent hang_check timer from firing at us during very long I/O */ > hang_check = sysctl_hung_task_timeout_secs; Looks good, Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de> -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index 0dc9a80..c2ef53a 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -351,6 +351,11 @@ int nvm_submit_ppa(struct nvm_dev *dev, struct ppa_addr *ppa, int nr_ppas, nvm_generic_to_addr_mode(dev, &rqd); ret = dev->ops->submit_io(dev, &rqd); + if (ret) { + nvm_free_rqd_ppalist(dev, &rqd); + bio_put(bio); + return ret; + } /* Prevent hang_check timer from firing at us during very long I/O */ hang_check = sysctl_hung_task_timeout_secs;
The device ->submit_io() callback might fail to submit I/O to device. In that case, the nvm_submit_ppa function should not wait for completion. Instead return the ->submit_io() error. Signed-off-by: Matias Bjørling <m@bjorling.me> --- drivers/lightnvm/core.c | 5 +++++ 1 file changed, 5 insertions(+)