From patchwork Wed Apr 27 11:50:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Matias_Bj=C3=B8rling?= X-Patchwork-Id: 8955941 Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7EA7D9F1D3 for ; Wed, 27 Apr 2016 11:51:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8B6CE201C7 for ; Wed, 27 Apr 2016 11:51:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 75865201BB for ; Wed, 27 Apr 2016 11:51:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752826AbcD0LvA (ORCPT ); Wed, 27 Apr 2016 07:51:00 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:34923 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752211AbcD0Lu7 (ORCPT ); Wed, 27 Apr 2016 07:50:59 -0400 Received: by mail-wm0-f43.google.com with SMTP id e201so35059478wme.0 for ; Wed, 27 Apr 2016 04:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bjorling.me; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aoukxTm9nXcixr+ZVuMoBUVHNZ+c85eZyIXJDhGjDHo=; b=EW3fbqZTSKhgpjHc1kuoE9zymgd4IE0Fo3OyIWBpmqkWE4GluZYa7O1/I1P4LE4PgH r1GPk62bkUM9ueCf6YfMTodMiZQ3IE9GX1mrKiJYkJL7V25mbgiYOryFWEVN0LR7i2gz 7Mqks3RScTF19ZBtEEUVIYksTPtvx6EzlR/II= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aoukxTm9nXcixr+ZVuMoBUVHNZ+c85eZyIXJDhGjDHo=; b=keVggGoeT0wFMcBrCg7EOa4zqe+VfRiEQD+dxMAbJvEazmP8XtZp+zGnoDOpF0Sszp E2AzUYyrsizq/p3FfRC0g16gITfCejcb6hPWO2QN4QU4DXkVF+E+UvSHNx3hs3VYvafr S7lJ6I5NGttEgfojI0GMbEl7CAmTck2QtGerswoApwlVssEni4jjcyPWsqfxtEzqKB1G kcqvsv9KESKMc88hgQmw3odCR46pJiC4HIld+32JJL8gmsC+e33FixXEB7Tt66GGv9KT x1nCzSIqRsrVDeZAWamYHoYxQMk32A/qF3g0ToAmJWXRt7jHcaiyCPjn79p94wPCm03w uJIA== X-Gm-Message-State: AOPr4FURVZobK+QLRRomfYxiyztm/F3ZBeksjsmvRcdcPzgtzcophrfsQh8RP99ZRfKXLQ== X-Received: by 10.28.30.78 with SMTP id e75mr25435256wme.88.1461757857842; Wed, 27 Apr 2016 04:50:57 -0700 (PDT) Received: from Macroninja.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id ju3sm3684846wjb.11.2016.04.27.04.50.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 27 Apr 2016 04:50:57 -0700 (PDT) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Cc: =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 1/2] lightnvm: move responsibility for bad blk mgmt to target Date: Wed, 27 Apr 2016 13:50:13 +0200 Message-Id: <1461757814-7086-1-git-send-email-m@bjorling.me> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We move the responsibility of managing the persistent bad block table to the target. The target may choose to mark a block bad or retry writing to it. Never the less, it should be the target that makes the decision and not the media manager. Signed-off-by: Matias Bjørling --- drivers/lightnvm/gennvm.c | 34 +++++++++++++++------------------- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/drivers/lightnvm/gennvm.c b/drivers/lightnvm/gennvm.c index 6096077..6f1c420 100644 --- a/drivers/lightnvm/gennvm.c +++ b/drivers/lightnvm/gennvm.c @@ -408,6 +408,9 @@ static void gennvm_blk_set_type(struct nvm_dev *dev, struct ppa_addr *ppa, struct gen_lun *lun; struct nvm_block *blk; + pr_debug("gennvm: ppa (ch: %u lun: %u blk: %u pg: %u) -> %u\n", + ppa->g.ch, ppa->g.lun, ppa->g.blk, ppa->g.pg, type); + if (unlikely(ppa->g.ch > dev->nr_chnls || ppa->g.lun > dev->luns_per_chnl || ppa->g.blk > dev->blks_per_lun)) { @@ -426,39 +429,32 @@ static void gennvm_blk_set_type(struct nvm_dev *dev, struct ppa_addr *ppa, blk->state = type; } -/* mark block bad. It is expected the target recover from the error. */ +/* + * mark block bad in gennvm. It is expected that the target recovers separately + */ static void gennvm_mark_blk_bad(struct nvm_dev *dev, struct nvm_rq *rqd) { - int i; - - if (!dev->ops->set_bb_tbl) - return; - - if (dev->ops->set_bb_tbl(dev, rqd, 1)) - return; + int bit = -1; + int max_secs = dev->ops->max_phys_sect; + void *comp_bits = &rqd->ppa_status; nvm_addr_to_generic_mode(dev, rqd); /* look up blocks and mark them as bad */ - if (rqd->nr_pages > 1) - for (i = 0; i < rqd->nr_pages; i++) - gennvm_blk_set_type(dev, &rqd->ppa_list[i], - NVM_BLK_ST_BAD); - else + if (rqd->nr_pages == 1) gennvm_blk_set_type(dev, &rqd->ppa_addr, NVM_BLK_ST_BAD); + return; + + while ((bit = find_next_bit(comp_bits, max_secs, bit + 1)) < max_secs) + gennvm_blk_set_type(dev, &rqd->ppa_list[bit], NVM_BLK_ST_BAD); } static void gennvm_end_io(struct nvm_rq *rqd) { struct nvm_tgt_instance *ins = rqd->ins; - switch (rqd->error) { - case NVM_RSP_SUCCESS: - case NVM_RSP_ERR_EMPTYPAGE: - break; - case NVM_RSP_ERR_FAILWRITE: + if (rqd->error == NVM_RSP_ERR_FAILWRITE) gennvm_mark_blk_bad(rqd->dev, rqd); - } ins->tt->end_io(rqd); }