From patchwork Fri May 6 18:03:08 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Matias_Bj=C3=B8rling?= X-Patchwork-Id: 9035461 Return-Path: X-Original-To: patchwork-linux-block@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E399D9F1D3 for ; Fri, 6 May 2016 18:09:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 02BC020220 for ; Fri, 6 May 2016 18:09:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14576200E9 for ; Fri, 6 May 2016 18:09:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758765AbcEFSDu (ORCPT ); Fri, 6 May 2016 14:03:50 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:37169 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758761AbcEFSDt (ORCPT ); Fri, 6 May 2016 14:03:49 -0400 Received: by mail-wm0-f41.google.com with SMTP id a17so89988202wme.0 for ; Fri, 06 May 2016 11:03:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bjorling.me; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w9iqAc8h+BoeX6ISbHI3aqOTPdDJc/yQZ5JkNn2sEyo=; b=Qo+Q/DCQ0IVa4iG1CCPNkX3MAzTbeyRa2dK7oq7eNsvvh6yX8+39Po+xTyLaPnJbeZ yq51wfsiv5SsL04Mjl9fg/ZRXwEjOZEzwrKLKNeWUHoswR0HLyMXa4MqKNgubDXHma5J u+fWYXhLMOYcpSsFltCqnTMF+N+cdh/921Yh8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w9iqAc8h+BoeX6ISbHI3aqOTPdDJc/yQZ5JkNn2sEyo=; b=FRc0aigyMrCR7sd5bMeaqmXBDTmD+bKVfmQg2dwqDYkQKX27alAuyg3Imoygmd2esz 04MOJZUOkx3iGqpZtzvRjLz25hE1r7kdl78D+e/h1anBRJCtdgqzi6tZziYnvXe+o7PI TOEDAV/RGFNZdSjRI+yjSTAgNAP25+Jvx5DaZzayr8tOoOIpQMsNzLVVxqolCtm5GQ3I 6NsfDCUFGyKePrA26scUuTMoU8yiWuXLnmQ/FU8ajaKfInCMCI4ZIgyFooI+iPS0Y7Ej cWfIXwYCPNWHllScq9mLOJA/PQFTy34bHMjWhQk6IuHU4vItZszymEGaAYc9/Q4wo15q C5Tw== X-Gm-Message-State: AOPr4FVlS+3X+46QgWJ0H09ZbljSt7TAJEc7dST225r1+vknJK5zfzZJt+WigKm1/y5LYA== X-Received: by 10.195.11.197 with SMTP id ek5mr21388002wjd.58.1462557827791; Fri, 06 May 2016 11:03:47 -0700 (PDT) Received: from Macroninja.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id kz1sm16076559wjc.46.2016.05.06.11.03.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 06 May 2016 11:03:47 -0700 (PDT) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@fb.com Cc: =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 15/28] lightnvm: move responsibility for bad blk mgmt to target Date: Fri, 6 May 2016 20:03:08 +0200 Message-Id: <1462557801-24974-16-git-send-email-m@bjorling.me> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1462557801-24974-1-git-send-email-m@bjorling.me> References: <1462557801-24974-1-git-send-email-m@bjorling.me> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We move the responsibility of managing the persistent bad block table to the target. The target may choose to mark a block bad or retry writing to it. Never the less, it should be the target that makes the decision and not the media manager. Signed-off-by: Matias Bjørling --- drivers/lightnvm/gennvm.c | 35 ++++++++++++++++------------------- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/lightnvm/gennvm.c b/drivers/lightnvm/gennvm.c index 9c6b141..89b880a 100644 --- a/drivers/lightnvm/gennvm.c +++ b/drivers/lightnvm/gennvm.c @@ -419,6 +419,9 @@ static void gennvm_blk_set_type(struct nvm_dev *dev, struct ppa_addr *ppa, struct gen_lun *lun; struct nvm_block *blk; + pr_debug("gennvm: ppa (ch: %u lun: %u blk: %u pg: %u) -> %u\n", + ppa->g.ch, ppa->g.lun, ppa->g.blk, ppa->g.pg, type); + if (unlikely(ppa->g.ch > dev->nr_chnls || ppa->g.lun > dev->luns_per_chnl || ppa->g.blk > dev->blks_per_lun)) { @@ -437,39 +440,33 @@ static void gennvm_blk_set_type(struct nvm_dev *dev, struct ppa_addr *ppa, blk->state = type; } -/* mark block bad. It is expected the target recover from the error. */ +/* + * mark block bad in gennvm. It is expected that the target recovers separately + */ static void gennvm_mark_blk_bad(struct nvm_dev *dev, struct nvm_rq *rqd) { - int i; - - if (!dev->ops->set_bb_tbl) - return; - - if (dev->ops->set_bb_tbl(dev, rqd, 1)) - return; + int bit = -1; + int max_secs = dev->ops->max_phys_sect; + void *comp_bits = &rqd->ppa_status; nvm_addr_to_generic_mode(dev, rqd); /* look up blocks and mark them as bad */ - if (rqd->nr_pages > 1) - for (i = 0; i < rqd->nr_pages; i++) - gennvm_blk_set_type(dev, &rqd->ppa_list[i], - NVM_BLK_ST_BAD); - else + if (rqd->nr_pages == 1) { gennvm_blk_set_type(dev, &rqd->ppa_addr, NVM_BLK_ST_BAD); + return; + } + + while ((bit = find_next_bit(comp_bits, max_secs, bit + 1)) < max_secs) + gennvm_blk_set_type(dev, &rqd->ppa_list[bit], NVM_BLK_ST_BAD); } static void gennvm_end_io(struct nvm_rq *rqd) { struct nvm_tgt_instance *ins = rqd->ins; - switch (rqd->error) { - case NVM_RSP_SUCCESS: - case NVM_RSP_ERR_EMPTYPAGE: - break; - case NVM_RSP_ERR_FAILWRITE: + if (rqd->error == NVM_RSP_ERR_FAILWRITE) gennvm_mark_blk_bad(rqd->dev, rqd); - } ins->tt->end_io(rqd); }