From patchwork Mon Dec 5 21:18:20 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Krinkin X-Patchwork-Id: 9461511 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3648E60231 for ; Mon, 5 Dec 2016 21:18:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2A2772807E for ; Mon, 5 Dec 2016 21:18:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1D1DA280B0; Mon, 5 Dec 2016 21:18:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BB14C2807E for ; Mon, 5 Dec 2016 21:18:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750960AbcLEVS1 (ORCPT ); Mon, 5 Dec 2016 16:18:27 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:36829 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbcLEVS0 (ORCPT ); Mon, 5 Dec 2016 16:18:26 -0500 Received: by mail-lf0-f66.google.com with SMTP id o20so27020618lfg.3 for ; Mon, 05 Dec 2016 13:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=H1cmDe8x4+py2bdlBX7pGi4/2FB0Rgci2CSYLAL6nro=; b=FG7LlX53OBxsq7y8Ahi30QOsWG1YnCYvlkT6N2Y7FYpMvSWcJFUayhxAE31PjpyHwF UztiU/M3dxnCAi1lu4FEFBvBTqonAhs6HCGuM37smLWKdOvuMHuUwM3B3r11BDlJQye7 +OPEX8W48FNH077ZpQszC0V4KkH1gYnvq0pw7GjFxXvJg590gPBaZLY60e9DLplA1OYC oG1Mrrp1m3gRZJg3rxN2g1/+U+pVU2Kk/aasnvC869nSL2fnEouqukRRqRH1VA2KP3Xt K6P5/4Ni60PKh2hqvPuYLXY3KYfneB/wDWjb3JU6uikYxpH4yzcU2b2QVU5k0qeWtk5R 9jxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=H1cmDe8x4+py2bdlBX7pGi4/2FB0Rgci2CSYLAL6nro=; b=gLQEt/sClKPfgw+iEnl+2c/94e9IkbIc8diTO8+I37dvxdIMNgT1lXNdSkG//BiCqi AtBlJEPKD91+fzzv/4yCgbiD4YT6anGYrAv/kbbWrWErW+gmg+vN00kvRbFwEqyCV4Kv HqnUtCvVn9PcV+qI3TtS9Z41275L3OQKn3e594BvI0oU6RpWF0Gb0pUbvsDxhBlwYNhz QTjl9fKUKGOdfglZFf0EpuyTpqoK5JMVwLuupGxvZ8jlB7cqkca7d+O3wXZ8jY0imuh6 TY8/5qCfDTbM2ZUIDdcUGFGYg2LNnXLDhKaBKd58VIc4f3yXoqhe1tQWh7qmHnceKpLh utmA== X-Gm-Message-State: AKaTC03KFzp65etFejW8kIhtkdbkajekjzFRoylLrWIPbnXSBl4SDsWSY9JLaqoMQKQlvw== X-Received: by 10.25.104.20 with SMTP id d20mr18436016lfc.59.1480972704972; Mon, 05 Dec 2016 13:18:24 -0800 (PST) Received: from localhost.localdomain ([94.19.214.170]) by smtp.gmail.com with ESMTPSA id a9sm3244498ljb.9.2016.12.05.13.18.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 05 Dec 2016 13:18:23 -0800 (PST) From: Mike Krinkin To: axboe@kernel.dk Cc: linux-block@vger.kernel.org, hch@lst.de, martin.petersen@oracle.com, hare@suse.de, shaun@tancheff.com, damien.lemoal@hgst.com, shaun.tancheff@seagate.com, chaitanya.kulkarni@hgst.com, Mike Krinkin Subject: [PATCH] block: Add missed break in generic_make_request_checks Date: Tue, 6 Dec 2016 00:18:20 +0300 Message-Id: <1480972700-3873-1-git-send-email-krinkin.m.u@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP With recent linux-next i started to get this error: [ 19.746764] EXT4-fs (sda6): Delayed block allocation failed for inode 4999023 at logical offset 0 with max blocks 6 with error 95 [ 19.746767] EXT4-fs (sda6): This should not happen!! Data will be lost Bisect points at the commit e73c23ff736e ("block: add async variant of blkdev_issue_zeroout") but i think that the real problem is a missed break in the commit 2d253440b5af ("block: Define zoned block device operations"). Fixes: 2d253440b5af ("block: Define zoned block device operations") Signed-off-by: Mike Krinkin --- block/blk-core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/blk-core.c b/block/blk-core.c index 24de87d..1998aa4 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1947,6 +1947,7 @@ generic_make_request_checks(struct bio *bio) case REQ_OP_WRITE_SAME: if (!bdev_write_same(bio->bi_bdev)) goto not_supported; + break; case REQ_OP_ZONE_REPORT: case REQ_OP_ZONE_RESET: if (!bdev_is_zoned(bio->bi_bdev))