| Message ID | 1481863316-6736-1-git-send-email-riteshh@codeaurora.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 12/16/2016 05:41 AM, Ritesh Harjani wrote: > Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org> > --- > include/linux/blkdev.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 286b2a2..8369564 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -288,7 +288,6 @@ enum blk_queue_state { > struct blk_queue_tag { > struct request **tag_index; /* map of busy tags */ > unsigned long *tag_map; /* bit map of free/busy tags */ > - int busy; /* current depth */ > int max_depth; /* what we will send to device */ > int real_max_depth; /* what the array can hold */ > atomic_t refcnt; /* map can be shared */ > That's a good catch. Was this detected manually or did you use a tool to detect this? Anyway: Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> -- To unsubscribe from this list: send the line "unsubscribe linux-block" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/16/2016 3:57 PM, Bart Van Assche wrote: > On 12/16/2016 05:41 AM, Ritesh Harjani wrote: >> Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org> >> --- >> include/linux/blkdev.h | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h >> index 286b2a2..8369564 100644 >> --- a/include/linux/blkdev.h >> +++ b/include/linux/blkdev.h >> @@ -288,7 +288,6 @@ enum blk_queue_state { >> struct blk_queue_tag { >> struct request **tag_index; /* map of busy tags */ >> unsigned long *tag_map; /* bit map of free/busy tags */ >> - int busy; /* current depth */ >> int max_depth; /* what we will send to device */ >> int real_max_depth; /* what the array can hold */ >> atomic_t refcnt; /* map can be shared */ >> > > That's a good catch. Was this detected manually or did you use a tool to > detect this? Anyway: Manually, while I was reading this code. > > Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> >
On 12/15/2016 09:41 PM, Ritesh Harjani wrote: > Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org> > --- > include/linux/blkdev.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 286b2a2..8369564 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -288,7 +288,6 @@ enum blk_queue_state { > struct blk_queue_tag { > struct request **tag_index; /* map of busy tags */ > unsigned long *tag_map; /* bit map of free/busy tags */ > - int busy; /* current depth */ > int max_depth; /* what we will send to device */ > int real_max_depth; /* what the array can hold */ > atomic_t refcnt; /* map can be shared */ Applied, thanks.
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 286b2a2..8369564 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -288,7 +288,6 @@ enum blk_queue_state { struct blk_queue_tag { struct request **tag_index; /* map of busy tags */ unsigned long *tag_map; /* bit map of free/busy tags */ - int busy; /* current depth */ int max_depth; /* what we will send to device */ int real_max_depth; /* what the array can hold */ atomic_t refcnt; /* map can be shared */
Signed-off-by: Ritesh Harjani <riteshh@codeaurora.org> --- include/linux/blkdev.h | 1 - 1 file changed, 1 deletion(-)