| Message ID | 149266673005.27388.9415706764616504556.stgit@noble (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
On Thu, Apr 20, 2017 at 03:38:50PM +1000, NeilBrown wrote: > This function allocates a bio, then a collection > of pages. It copes with failure. > > It currently uses a mempool() to allocate the bio, > but alloc_page() to allocate the pages. These fail > in different ways, so the usage is inconsistent. > > Change the bio_clone() to bio_clone_kmalloc() > so that no pool is used either for the bio or the pages. > > Signed-off-by: NeilBrown <neilb@suse.com> Acked-by: Kent Overstreet <kent.overstreet@gmail.com>` > --- > drivers/md/bcache/debug.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c > index 06f55056aaae..35a5a7210e51 100644 > --- a/drivers/md/bcache/debug.c > +++ b/drivers/md/bcache/debug.c > @@ -110,7 +110,7 @@ void bch_data_verify(struct cached_dev *dc, struct bio *bio) > struct bio_vec bv, cbv; > struct bvec_iter iter, citer = { 0 }; > > - check = bio_clone(bio, GFP_NOIO); > + check = bio_clone_kmalloc(bio, GFP_NOIO); > if (!check) > return; > check->bi_opf = REQ_OP_READ; > >
On Thu, Apr 20, 2017 at 1:38 PM, NeilBrown <neilb@suse.com> wrote: > This function allocates a bio, then a collection > of pages. It copes with failure. > > It currently uses a mempool() to allocate the bio, > but alloc_page() to allocate the pages. These fail > in different ways, so the usage is inconsistent. > > Change the bio_clone() to bio_clone_kmalloc() > so that no pool is used either for the bio or the pages. > > Signed-off-by: NeilBrown <neilb@suse.com> Reviewed-by : Ming Lei <ming.lei@redhat.com> Thanks, Ming Lei
diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c index 06f55056aaae..35a5a7210e51 100644 --- a/drivers/md/bcache/debug.c +++ b/drivers/md/bcache/debug.c @@ -110,7 +110,7 @@ void bch_data_verify(struct cached_dev *dc, struct bio *bio) struct bio_vec bv, cbv; struct bvec_iter iter, citer = { 0 }; - check = bio_clone(bio, GFP_NOIO); + check = bio_clone_kmalloc(bio, GFP_NOIO); if (!check) return; check->bi_opf = REQ_OP_READ;
This function allocates a bio, then a collection of pages. It copes with failure. It currently uses a mempool() to allocate the bio, but alloc_page() to allocate the pages. These fail in different ways, so the usage is inconsistent. Change the bio_clone() to bio_clone_kmalloc() so that no pool is used either for the bio or the pages. Signed-off-by: NeilBrown <neilb@suse.com> --- drivers/md/bcache/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)