From patchwork Wed May 3 09:19:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9709047 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6EB2D60351 for ; Wed, 3 May 2017 09:19:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 73AE528602 for ; Wed, 3 May 2017 09:19:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 672882860D; Wed, 3 May 2017 09:19:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD66328602 for ; Wed, 3 May 2017 09:19:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752658AbdECJT3 (ORCPT ); Wed, 3 May 2017 05:19:29 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37642 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752647AbdECJT1 (ORCPT ); Wed, 3 May 2017 05:19:27 -0400 Received: by mail-wm0-f47.google.com with SMTP id m123so49852529wma.0 for ; Wed, 03 May 2017 02:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=h1f181v81UmzLlEPm5Mu4TJ+GMyyyTCCQOs5OPbRfRo=; b=YP50Guxz+Q1UbnFj3lO/YSlj836FVQOUYcpofA4QjIgNhYFLeyG3PPkOZjfLP7OElK Xa1N8AM/sfiZuPX2lpMi12GS0tolePs1dmgZDWLFc4ER6Nfn6gdErALxNsCHvE596LU0 BV+L4RfiHhFbEh9iEUiWpu6xcWti8Z2YF1EHOpX5I+m/BMsyGK3sgULZ7VPDUSz+hkMW sAUlTDAxkKSTGkzxutqR5in+/aBTVARxSH8QIzhZm1YOhf3V6e71e6Hzsp6nxvKbv8ZR hVnlRrXJhiklY6P+TlUYaaeYblxZW3ai3QrJORksa/jtJ7c98qlfA4IzEoH+fwDQIKNn v2eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=h1f181v81UmzLlEPm5Mu4TJ+GMyyyTCCQOs5OPbRfRo=; b=JJKMF1Yp8DmGNLr5qF0iN2hE9u717uzOpKLl4X8lgSM+/c0ffPZB+23OuLGsOg4XEf wAxPAFXPA1Q4bT9E+SsCdvLxh4a+wSsD0966nuzS9P15VklrEUF+4HASIxaqyObhodKu XxW5A4Xp4SG1Vra7vXR0pUgUB6+cWBJ2ifZH3nX61HooEGbbzNM1tBzJZVx73IZ4kZ8T YcLqUAoJIfyH1usQG/AP/pTBRR96E5RSHeuwew5MIYmjZToIIggj7D/xkBSmmIdAkPse S9e0tmnEY6szjtWz6DM/62Cajd8UDNr7leiE2wCSMCPNLf+MmtDPIvQv9j3hm1d8ibO4 8UEg== X-Gm-Message-State: AN3rC/6DCTEMAUdqhPjggnbu851I4wDyqW5VE8zC/X7pnWJDQgmEB6/s 2ILX9PKnM2F0Ew== X-Received: by 10.80.173.113 with SMTP id z46mr11947933edc.111.1493803166300; Wed, 03 May 2017 02:19:26 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id x2sm10152667edb.49.2017.05.03.02.19.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 May 2017 02:19:25 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= Subject: [PATCH 1/2] lightnvm: create cmd before allocating request Date: Wed, 3 May 2017 11:19:04 +0200 Message-Id: <1493803145-18082-1-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Create nvme command before allocating a request using nvme_alloc_request, which uses the command direction. Up until now, the command has been zeroized, so all commands have been allocated as a read operation. Signed-off-by: Javier González Reviewed-by: Matias Bjørling Reviewed-by: Christoph Hellwig --- drivers/nvme/host/lightnvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c index de61a4a03d78..090bbeb655bc 100644 --- a/drivers/nvme/host/lightnvm.c +++ b/drivers/nvme/host/lightnvm.c @@ -503,6 +503,8 @@ static int nvme_nvm_submit_io(struct nvm_dev *dev, struct nvm_rq *rqd) if (!cmd) return -ENOMEM; + nvme_nvm_rqtocmd(rq, rqd, ns, cmd); + rq = nvme_alloc_request(q, (struct nvme_command *)cmd, 0, NVME_QID_ANY); if (IS_ERR(rq)) { kfree(cmd); @@ -517,8 +519,6 @@ static int nvme_nvm_submit_io(struct nvm_dev *dev, struct nvm_rq *rqd) rq->__data_len = 0; } - nvme_nvm_rqtocmd(rq, rqd, ns, cmd); - rq->end_io_data = rqd; blk_execute_rq_nowait(q, NULL, rq, 0, nvme_nvm_end_io);