From patchwork Mon Jun 26 09:57:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9809029 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CE63960209 for ; Mon, 26 Jun 2017 10:00:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D59082847B for ; Mon, 26 Jun 2017 10:00:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C959A2847D; Mon, 26 Jun 2017 10:00:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5CC952847B for ; Mon, 26 Jun 2017 10:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752096AbdFZJ66 (ORCPT ); Mon, 26 Jun 2017 05:58:58 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37892 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751477AbdFZJ6O (ORCPT ); Mon, 26 Jun 2017 05:58:14 -0400 Received: by mail-wm0-f42.google.com with SMTP id b184so3025722wme.1 for ; Mon, 26 Jun 2017 02:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qs8uk80eBc2Cil4PR8JPVWKZ6KjpajrevlXLP12l/Gw=; b=l16Gz0DgY1ItN5ft5f/Lzr7DhKYN1F8G2FACMzxhLuhlPEAl2KL4u41jJbSLd5noIZ vmC2m5D2k6GvFtAaaz/1AZEwKPh2E3RxpoQDwm9oaLD43LcNwQInfgY8qk1A+tWdynYQ iz07AbT/WZD0OmztDd2Ek1LXqA0o4tHMaoxu8VeQHFrHRjNoDU0rAaOMw7dzVsZxZkyo Xl354mUh9uw11O6KGoWfQDcySD8EsR4mUArjKCxwJ1bkXyt4W4R0XvGl9kZcKvYv6xZw Vy8usaDQuxgA16ISw3uikJ007ufUqzWELV9PLMHMBMw4bHQvmlGugp1u9WCNHT7yM+uR MVxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qs8uk80eBc2Cil4PR8JPVWKZ6KjpajrevlXLP12l/Gw=; b=Fe83d0YRzpB2/w1YOXI/rqOyMXn0JbAUo0k9aMw5whEvHEQ2u5AWlyKpPpDftJPWop JdoHXgys9o1Tmr3Jx3fGR1y/NZtRoRGiEeIagzqSP7F82rq+HG/N8QZZH0UgeE9RLHig hUSDZsjKUqGxQr2kLdTAeIqF3muAAii4EAYpYJyU3wa7JYYkwP/LOPq5FXsS6lWbvWq+ gYVc6dSwPUw+zOwyROtRYSSjFhn66CdTP1ZjijBorlo2LK9ayCjGrJy41PSkDsuycHxr HB1RJ9MyZ91vk/d8ozvBVez4oFLhR0bKxUFEKV6BA/LIiir4/oOW8Hjxwk1gs3sPAy/T zRXQ== X-Gm-Message-State: AKS2vOwoj/UMheibXD2pMtFIlEZtoGPOKBvkmHz2s6TjoZ2CGuxCnLww HNacLpt6s7bdkgMN X-Received: by 10.80.170.115 with SMTP id p48mr16639015edc.33.1498471092843; Mon, 26 Jun 2017 02:58:12 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id n26sm5212537edd.51.2017.06.26.02.58.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 26 Jun 2017 02:58:12 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io, axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 03/20] lightnvm: pblk: spare double cpu_to_le64 calc. Date: Mon, 26 Jun 2017 11:57:12 +0200 Message-Id: <1498471049-25505-4-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498471049-25505-1-git-send-email-javier@cnexlabs.com> References: <1498471049-25505-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Spare a double calculation on the fast write path. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-map.c | 5 +++-- drivers/lightnvm/pblk-recovery.c | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/lightnvm/pblk-map.c b/drivers/lightnvm/pblk-map.c index 17c16955284d..18291c238930 100644 --- a/drivers/lightnvm/pblk-map.c +++ b/drivers/lightnvm/pblk-map.c @@ -53,8 +53,9 @@ static void pblk_map_page_data(struct pblk *pblk, unsigned int sentry, lba_list[paddr] = cpu_to_le64(w_ctx->lba); le64_add_cpu(&line->emeta->nr_valid_lbas, 1); } else { - meta_list[i].lba = cpu_to_le64(ADDR_EMPTY); - lba_list[paddr] = cpu_to_le64(ADDR_EMPTY); + u64 addr_empty = cpu_to_le64(ADDR_EMPTY); + + lba_list[paddr] = meta_list[i].lba = addr_empty; pblk_map_pad_invalidate(pblk, line, paddr); } } diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recovery.c index f8f85087cd3c..82787006b865 100644 --- a/drivers/lightnvm/pblk-recovery.c +++ b/drivers/lightnvm/pblk-recovery.c @@ -390,12 +390,12 @@ static int pblk_recov_pad_oob(struct pblk *pblk, struct pblk_line *line, for (j = 0; j < pblk->min_write_pgs; j++, i++, w_ptr++) { struct ppa_addr dev_ppa; + u64 addr_empty = cpu_to_le64(ADDR_EMPTY); dev_ppa = addr_to_gen_ppa(pblk, w_ptr, line->id); pblk_map_invalidate(pblk, dev_ppa); - meta_list[i].lba = cpu_to_le64(ADDR_EMPTY); - lba_list[w_ptr] = cpu_to_le64(ADDR_EMPTY); + lba_list[w_ptr] = meta_list[i].lba = addr_empty; rqd->ppa_list[i] = dev_ppa; } }