From patchwork Fri Jun 30 15:56:41 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= X-Patchwork-Id: 9819905 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5218E602B1 for ; Fri, 30 Jun 2017 15:57:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C3B32853B for ; Fri, 30 Jun 2017 15:57:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 10CD7286AC; Fri, 30 Jun 2017 15:57:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A67182853B for ; Fri, 30 Jun 2017 15:57:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbdF3P5C (ORCPT ); Fri, 30 Jun 2017 11:57:02 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:34893 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbdF3P5A (ORCPT ); Fri, 30 Jun 2017 11:57:00 -0400 Received: by mail-wm0-f42.google.com with SMTP id w126so113905023wme.0 for ; Fri, 30 Jun 2017 08:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IBh8hyPNbcKqOJG7DiL3JelFVRLlhvpYrlF6yDdWthI=; b=mkNL7PrpKJhwTFWbrFCvPV9VQalRsP5n3PfqhMKY84XI2lXIJGEDzhOl5VMB/swSCp LnYRGXI6Ssu6766O4cZGyddQ3HsbZ9W/BrP/CF+rWLHRozNbM1dJcuvZa4rZ9oAKAY27 rKr+ga6O8WHizQ3H+at0+bovP+T5Gl7PVAqCJZGhUa4aM8iIcR/i4WJY2AQggs8tHroi R3Yf3/QUcB+PrQ6Xw3FJP0Z4DWgOIv3sTZrJKCwU+1RZK471HB4DQ/BhIvZFWpyWGIIm mbR3TmzyqXBWxhi6gGKHQiBOxtR1SF5LJRzaotn8Z6t0laYMvPMD9aRFV4VhOvHFm8q2 MqNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IBh8hyPNbcKqOJG7DiL3JelFVRLlhvpYrlF6yDdWthI=; b=ijPvo2g45d4uK7kiNj82Bm9OnlRAL6rtXSs3nx/IcmkMrq1EKIw0IT3GvYBcOIdxnk w5BJbIQwx20AkUZcfQWUEyzNb2duIinNbzZUGGsALufv4WIQ6dagevYeQRY07SOnaReX 9/6SHP9fpIR7sHPSDpj9FbKfoyiCnp+CzmpobSoOIcLhh1mCWrDSZGF4gLm6cnAXLiQ6 TiUHovv/+RPVHKA4Ne64T1VfldSYAvbwv26CexjH8guyCfAxZxjJ9udTNDhaqhV12ZXL P9yaPvq3ePccrbJC3/gf6BNbJGLRtz4+GU4C0aB4IBjpT/4miDrMbwNZmusnfLJvLvjl YheQ== X-Gm-Message-State: AKS2vOw924SYtGNGuJ1sRCpSpgLdFS1uE2hm+o70PKJO0pWcGwW9e5se /+4Vr5uOn6VQqgm5 X-Received: by 10.80.134.141 with SMTP id r13mr5947083eda.77.1498838219152; Fri, 30 Jun 2017 08:56:59 -0700 (PDT) Received: from uHalley.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id d36sm2705988edb.63.2017.06.30.08.56.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 30 Jun 2017 08:56:58 -0700 (PDT) From: "=?UTF-8?q?Javier=20Gonz=C3=A1lez?=" X-Google-Original-From: =?UTF-8?q?Javier=20Gonz=C3=A1lez?= To: mb@lightnvm.io, axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Javier=20Gonz=C3=A1lez?= , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [PATCH 08/10] lightnvm: pblk: add initialization check Date: Fri, 30 Jun 2017 17:56:41 +0200 Message-Id: <1498838203-21539-9-git-send-email-javier@cnexlabs.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1498838203-21539-1-git-send-email-javier@cnexlabs.com> References: <1498838203-21539-1-git-send-email-javier@cnexlabs.com> MIME-Version: 1.0 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add a sanity check to the pblk initialization sequence in order to ensure that enough LUNs have been allocated to store the line metadata. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-init.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c index 025d8fe52154..1b0f61233c21 100644 --- a/drivers/lightnvm/pblk-init.c +++ b/drivers/lightnvm/pblk-init.c @@ -716,6 +716,12 @@ static int pblk_lines_init(struct pblk *pblk) lm->emeta_bb = geo->nr_luns - i; lm->min_blk_line = 1 + DIV_ROUND_UP(lm->smeta_sec + lm->emeta_sec[0], geo->sec_per_blk); + if (lm->min_blk_line > lm->blk_per_line) { + pr_err("pblk: config. not supported. Min. LUN in line:%d\n", + lm->blk_per_line); + ret = -EINVAL; + goto fail; + } ret = pblk_lines_alloc_metadata(pblk); if (ret)