From patchwork Fri Sep 8 09:50:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luca Miccio X-Patchwork-Id: 9943513 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A91A560224 for ; Fri, 8 Sep 2017 09:50:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9AFF228607 for ; Fri, 8 Sep 2017 09:50:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8D90E28620; Fri, 8 Sep 2017 09:50:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E1C2928620 for ; Fri, 8 Sep 2017 09:50:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752843AbdIHJuo (ORCPT ); Fri, 8 Sep 2017 05:50:44 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35803 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751654AbdIHJum (ORCPT ); Fri, 8 Sep 2017 05:50:42 -0400 Received: by mail-wr0-f196.google.com with SMTP id n64so1012999wrb.2; Fri, 08 Sep 2017 02:50:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=kUMwDqRMR2U9iosVxetVikS9uQ9rJM0nRqGRt/7jULc=; b=H+ziVJ6jwx1Z+k+DS2y3MuDQyhY8aOYXtYchP+CRAsuw0KbLXCLutnwYOqJqoyAFym KEbQtHdCESnVNyRzXPx+Jl/rSXHBystjwv4nMcnSEhABt0VRlmTIdF66hJSj3SyXqeNK A5UHHaWThBhiRthBo3XCT58BEg1wfGoXnUs8Y+GDOsLxk1MZyb/AUQNR/1ycypqnz46C urLmQTTG/gR69F1j2wfXym7UV5TTA5tkkKoJJamLa/9O9Ilit2bkiVPUHj1yR6Ae02Tt s2LX51JTa8Fvf3iGc3jACcj/Pe60Vcv4XOSP4GNGyzUDLDByQ6I2QkqiN/pOpxbDMhi0 cnsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=kUMwDqRMR2U9iosVxetVikS9uQ9rJM0nRqGRt/7jULc=; b=CZuhWeLP9jCQJSEQxb9uV8eGT8SxnJsuQo2CN9Cg5vMHF9Oinfz/Z2YenfU7zXoyop GlpTEVN8mpopdiMX3R4xPqnPIoIElSgwLteIAbr+WNgsSUywpJiaFVFW0A2yMmrmWurV uJ8BKt6qtweRR4BnV6q9bt08dD27+Mw1j1+nXEdzQ67xGAEdTJSaFmTy/PXBmUi0IOOK z14e/BGnx07VzirChUa1xeM+B5Njlfi8Ukx+VkZGZnXOR4irCKAKDzfJGb1g3Yc/4BZN QseJsewgduSzwyCXOA9+ou4MNjOEcLOQ3gXeg7sl6RUVoeq185UJzjs9VwpKTf2Y/+HG UxDw== X-Gm-Message-State: AHPjjUjfbMu8a0qecJGQ2PJBnIJQcA1Inqjg6Os5JyxhKEGCEpDM7gfG Sbpd+bxUlY0AOw== X-Google-Smtp-Source: ADKCNb4R3xqZFcyE3fR1Cs0mM7HVhij9rKbhAbnmit83F08iB9IvB6u4kiKNxPNi3BDECFBjS/JITg== X-Received: by 10.223.168.110 with SMTP id l101mr1869104wrc.215.1504864241451; Fri, 08 Sep 2017 02:50:41 -0700 (PDT) Received: from localhost.localdomain (93-36-158-157.ip60.fastwebnet.it. [93.36.158.157]) by smtp.gmail.com with ESMTPSA id c46sm1886628wrg.92.2017.09.08.02.50.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 08 Sep 2017 02:50:40 -0700 (PDT) From: Luca Miccio To: Jens Axboe Cc: Paolo Valente , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Miccio Subject: [PATCH] block,bfq: Disable writeback throttling Date: Fri, 8 Sep 2017 11:50:39 +0200 Message-Id: <1504864239-10288-1-git-send-email-lucmiccio@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Similarly to CFQ, BFQ has its write-throttling heuristics, and it is better not to combine them with further write-throttling heuristics of a different nature. So this commit disables write-back throttling for a device if BFQ is used as I/O scheduler for that device. Signed-off-by: Luca Miccio Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 436b6ca..4feae52 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -108,6 +108,7 @@ #include "blk-mq-tag.h" #include "blk-mq-sched.h" #include "bfq-iosched.h" +#include "blk-wbt.h" #define BFQ_BFQQ_FNS(name) \ void bfq_mark_bfqq_##name(struct bfq_queue *bfqq) \ @@ -4760,7 +4761,7 @@ static int bfq_init_queue(struct request_queue *q, struct elevator_type *e) bfq_init_root_group(bfqd->root_group, bfqd); bfq_init_entity(&bfqd->oom_bfqq.entity, bfqd->root_group); - + wbt_disable_default(q); return 0; out_free: