From patchwork Mon Oct 16 13:59:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ilya Dryomov X-Patchwork-Id: 10008443 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C4154601E7 for ; Mon, 16 Oct 2017 13:59:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B71A8285A2 for ; Mon, 16 Oct 2017 13:59:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ABF0E285AB; Mon, 16 Oct 2017 13:59:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 15122285A2 for ; Mon, 16 Oct 2017 13:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752494AbdJPN70 (ORCPT ); Mon, 16 Oct 2017 09:59:26 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:54875 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752284AbdJPN7Z (ORCPT ); Mon, 16 Oct 2017 09:59:25 -0400 Received: by mail-wm0-f68.google.com with SMTP id i124so3637516wmf.3 for ; Mon, 16 Oct 2017 06:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=dELdtiYHoYUAn3c1//UGOknQcfb4QsQpINIbzlQfloI=; b=m5hxXFldv1lwYz7j5njovjyLHvUOJyuJvS1xTJej4mk0oGtV4OGjRnYDtOiC5Tc33K HXKDmbPcBhCRebySf0bdZgGfmJ0YSo+jkq2KhOzbb+bZlQi84Jn6COrANkI5Bl/m2Mx7 4hFNAx2+ssuajVMmz02dL3P3F/USQmXoxTazGOblvfktukMHm2S3RhXaioasf9Jf01M/ fteYsIPFAjMvCIRCgvf+ZKoq2+01nq6gi+hgmEZnv5mr1BnDZPrH4ZcU7345OOiwBSWC TM3Fo7HhG2gLf1cwHrjvr2ibM8N91LJJc/Icjjz1sD5NIkofBHt1TSCVCcwlARLakx7g 4UlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=dELdtiYHoYUAn3c1//UGOknQcfb4QsQpINIbzlQfloI=; b=QIJor1FjczMNG5TSEVoviAQa3INd08n6t+SkifhYncVyktMMMgg/ShcKoOAD4+NdVp uvz5NNiEPAQsf83Rlx6V5ub93byBP2QxA0FP5DygsRh6myPRtnxW3twUX8J5xBfOgE29 krV92dTElIPm8Gxgr9kVM6wSCjzIVEjMZouSjYk05SCSd8e46Xln+EMEJ4lYoflflpYX ez4w5uu8c/Zu7KQNz7/rrBV6dA4kspKzo4sUL7LSiiJNjzhtSumOx/ID8+zvfWIkOFkD 68VFrMwXMF8zKTPYAoFINvEslfojEk7h5Vksf3piVjlGO84MpvTg0hXNfj2PDvMvoGq3 fAAw== X-Gm-Message-State: AMCzsaXSnoAm8WmbghQkkrWnZUtpAnPdE1eHCf1AwxVdZx0957o5qtg/ vsa+p7Bxb4jvR+K0eUNDdNg= X-Google-Smtp-Source: ABhQp+Se3lEmu+XO6N33fCuv8eNdkTUTgD+lhOjz5rjNslGuWwO7YE+N2oO84RUy8iAEJtCZE/8WxA== X-Received: by 10.223.185.19 with SMTP id k19mr774327wrf.76.1508162364129; Mon, 16 Oct 2017 06:59:24 -0700 (PDT) Received: from orange.brq.redhat.com. (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id e196sm18873305wmf.9.2017.10.16.06.59.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Oct 2017 06:59:23 -0700 (PDT) From: Ilya Dryomov To: Christoph Hellwig Cc: "Martin K. Petersen" , Hannes Reinecke , Jens Axboe , linux-block@vger.kernel.org Subject: [PATCH v3 2/2] block: cope with WRITE ZEROES failing in blkdev_issue_zeroout() Date: Mon, 16 Oct 2017 15:59:10 +0200 Message-Id: <1508162350-21978-3-git-send-email-idryomov@gmail.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1508162350-21978-1-git-send-email-idryomov@gmail.com> References: <1508162350-21978-1-git-send-email-idryomov@gmail.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP sd_config_write_same() ignores ->max_ws_blocks == 0 and resets it to permit trying WRITE SAME on older SCSI devices, unless ->no_write_same is set. Because REQ_OP_WRITE_ZEROES is implemented in terms of WRITE SAME, blkdev_issue_zeroout() may fail with -EREMOTEIO: $ fallocate -zn -l 1k /dev/sdg fallocate: fallocate failed: Remote I/O error $ fallocate -zn -l 1k /dev/sdg # OK $ fallocate -zn -l 1k /dev/sdg # OK The following calls succeed because sd_done() sets ->no_write_same in response to a sense that would become BLK_STS_TARGET/-EREMOTEIO, causing __blkdev_issue_zeroout() to fall back to generating ZERO_PAGE bios. This means blkdev_issue_zeroout() must cope with WRITE ZEROES failing and fall back to manually zeroing, unless BLKDEV_ZERO_NOFALLBACK is specified. For BLKDEV_ZERO_NOFALLBACK case, return -EOPNOTSUPP if sd_done() has just set ->no_write_same thus indicating lack of offload support. Fixes: c20cfc27a473 ("block: stop using blkdev_issue_write_same for zeroing") Cc: Christoph Hellwig Cc: "Martin K. Petersen" Cc: Hannes Reinecke Signed-off-by: Ilya Dryomov Reviewed-by: Christoph Hellwig Reviewed-by: Martin K. Petersen --- block/blk-lib.c | 45 +++++++++++++++++++++++++++++++++++---------- 1 file changed, 35 insertions(+), 10 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index 9d2ab8bba52a..23411ec7f3cc 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c @@ -321,12 +321,6 @@ static int __blkdev_issue_zero_pages(struct block_device *bdev, * Zero-fill a block range, either using hardware offload or by explicitly * writing zeroes to the device. * - * Note that this function may fail with -EOPNOTSUPP if the driver signals - * zeroing offload support, but the device fails to process the command (for - * some devices there is no non-destructive way to verify whether this - * operation is actually supported). In this case the caller should call - * retry the call to blkdev_issue_zeroout() and the fallback path will be used. - * * If a device is using logical block provisioning, the underlying space will * not be released if %flags contains BLKDEV_ZERO_NOUNMAP. * @@ -370,18 +364,49 @@ EXPORT_SYMBOL(__blkdev_issue_zeroout); int blkdev_issue_zeroout(struct block_device *bdev, sector_t sector, sector_t nr_sects, gfp_t gfp_mask, unsigned flags) { - int ret; - struct bio *bio = NULL; + int ret = 0; + sector_t bs_mask; + struct bio *bio; struct blk_plug plug; + bool try_write_zeroes = !!bdev_write_zeroes_sectors(bdev); + bs_mask = (bdev_logical_block_size(bdev) >> 9) - 1; + if ((sector | nr_sects) & bs_mask) + return -EINVAL; + +retry: + bio = NULL; blk_start_plug(&plug); - ret = __blkdev_issue_zeroout(bdev, sector, nr_sects, gfp_mask, - &bio, flags); + if (try_write_zeroes) { + ret = __blkdev_issue_write_zeroes(bdev, sector, nr_sects, + gfp_mask, &bio, flags); + } else if (!(flags & BLKDEV_ZERO_NOFALLBACK)) { + ret = __blkdev_issue_zero_pages(bdev, sector, nr_sects, + gfp_mask, &bio); + } else { + /* No zeroing offload support */ + ret = -EOPNOTSUPP; + } if (ret == 0 && bio) { ret = submit_bio_wait(bio); bio_put(bio); } blk_finish_plug(&plug); + if (ret && try_write_zeroes) { + if (!(flags & BLKDEV_ZERO_NOFALLBACK)) { + try_write_zeroes = false; + goto retry; + } + if (!bdev_write_zeroes_sectors(bdev)) { + /* + * Zeroing offload support was indicated, but the + * device reported ILLEGAL REQUEST (for some devices + * there is no non-destructive way to verify whether + * WRITE ZEROES is actually supported). + */ + ret = -EOPNOTSUPP; + } + } return ret; }