From patchwork Wed May 9 20:49:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 10390821 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A87C860236 for ; Wed, 9 May 2018 20:49:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A2CA286D1 for ; Wed, 9 May 2018 20:49:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 99043286E5; Wed, 9 May 2018 20:49:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CD8F286E0 for ; Wed, 9 May 2018 20:49:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935339AbeEIUtf (ORCPT ); Wed, 9 May 2018 16:49:35 -0400 Received: from mail-pl0-f68.google.com ([209.85.160.68]:45425 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935279AbeEIUte (ORCPT ); Wed, 9 May 2018 16:49:34 -0400 Received: by mail-pl0-f68.google.com with SMTP id bi12-v6so4988494plb.12 for ; Wed, 09 May 2018 13:49:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=e9ec99Iz7Ob9iUSLJfsyeXFQRtVCekK1FUtWy+bIcBY=; b=X3oGN5ODAke10IeJGYkIPKZaQ3xrSu4cWMBFlHT9CigxV7itRoP2nRCVndgY8gt8kD qM1N+t8kKhYNsQY1O1+4S3CuT5G1XpsKO4ICS3jtNm1TlVY46L+sWKDWB/sjdr7F6lyY xMpIylG2i+BggQgKQqMnVn9b0y1os7L18lND7RAyRk+yoO0Bz1mR0WTSc74Dms5tdFZS ht/p3MZAEUCbBMCwR69AVvOr8i1eozDkIP9FCuY4jfOdWoBAXzsBJpcm26ti+IkJROGX DgeKkPTGvMMk1FcX3xWDqddom2eAviQwK7sVOTgpoLq2giFP2I2jHKWaHAYGKYm65JXe lzMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=e9ec99Iz7Ob9iUSLJfsyeXFQRtVCekK1FUtWy+bIcBY=; b=PAK6J95I6tCpfndd24rJILBQJt49b1M+jevlhy4TfS9nxoW/e0gjgbUlmB9YF4sjBs esO3ge99HWuhdWVl+cRAxkO6b9uOWP4sv3sfCTd2pPhpncSKFNYCb0QGuu7Adn5tPb5P B7Xs/IBp5b42NRw1xwF2ochBnbq39LSuQh8vGLm8M3jyS2wCWyvDk+oj3U2HKS0R6yWB 0vASNifMz1BftK/HwkcI2jiuY7xeFJ2AQnAMA8IXCe4ATFJTnSX1QSn+JJKvHQjAaX+r tOc5zo7QRra7qYFwcsMHP4EFTiWrSrHz+g1S33zItM0DDGvYlBlJK1BB8O4R+V7RzG/E 09mw== X-Gm-Message-State: ALQs6tCyN5wC2U3KGpHqsMcaeOvO2gfVDWJf6KYEOOLEEMm1T1JJl76C cIpUzxObTvB0l1QGljvnxDYHycpe8oM= X-Google-Smtp-Source: AB8JxZpTwcugEvvBQFjpTav6gCLo0N/J8MQilmvPF6KLrbnvzJR46UZ9Zmeu4pRccXiBnm6grPMZfg== X-Received: by 2002:a17:902:758d:: with SMTP id j13-v6mr47137849pll.188.1525898973593; Wed, 09 May 2018 13:49:33 -0700 (PDT) Received: from x1.thefacebook.com ([2620:10d:c090:180::1:3111]) by smtp.gmail.com with ESMTPSA id b3sm25879337pff.132.2018.05.09.13.49.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 09 May 2018 13:49:32 -0700 (PDT) From: Jens Axboe To: linux-block@vger.kernel.org Cc: osandov@fb.com, efault@gmx.de, paolo.valente@linaro.org, Jens Axboe Subject: [PATCH 1/7] blk-mq: don't call into depth limiting for reserved tags Date: Wed, 9 May 2018 14:49:21 -0600 Message-Id: <1525898967-13425-2-git-send-email-axboe@kernel.dk> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1525898967-13425-1-git-send-email-axboe@kernel.dk> References: <1525898967-13425-1-git-send-email-axboe@kernel.dk> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It's not useful, they are internal and/or error handling recovery commands. Signed-off-by: Jens Axboe --- block/blk-mq.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 4e9d83594cca..64630caaf27e 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -360,9 +360,11 @@ static struct request *blk_mq_get_request(struct request_queue *q, /* * Flush requests are special and go directly to the - * dispatch list. + * dispatch list. Don't include reserved tags in the + * limiting, as it isn't useful. */ - if (!op_is_flush(op) && e->type->ops.mq.limit_depth) + if (!op_is_flush(op) && e->type->ops.mq.limit_depth && + !(data->flags & BLK_MQ_REQ_RESERVED)) e->type->ops.mq.limit_depth(op, data); }