From patchwork Wed Aug 29 12:23:33 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans Holmberg X-Patchwork-Id: 10580127 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0ADB314BD for ; Wed, 29 Aug 2018 12:24:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE1DF2A6CF for ; Wed, 29 Aug 2018 12:24:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E21C22A70A; Wed, 29 Aug 2018 12:24:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7DF5A2A6CF for ; Wed, 29 Aug 2018 12:24:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728242AbeH2QUv (ORCPT ); Wed, 29 Aug 2018 12:20:51 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:44158 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728167AbeH2QUj (ORCPT ); Wed, 29 Aug 2018 12:20:39 -0400 Received: by mail-ed1-f67.google.com with SMTP id s10-v6so3757421edb.11 for ; Wed, 29 Aug 2018 05:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owltronix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iBg1uCqOePo2LDQD2c20wRoYMAK/OSTDbgOTeB8gv9s=; b=VTH3oS/evm991XifbHxtoLWtJba9u+i+SMVE79aiZQYpTlVXJpLT07prOzvdrhecvG Fqg1V1tY69ZHsQwYYr3KygrZ2LAWrLCC7g6HJLm/5ZtGeTALAa663TethDCgCxGpELyh LqQxov5J3ozG5UXK+pQljH+/WP3j+fSU8vzn5d2Vmtp9nJLF+2uNxOL2ASts6na1DzUR fJ/OLIs1Ttwqo/SuQy+It/jUA8Ksl6+Bp3nNL+BtNYd47m3KFfyt7E4Fd48fFtmSFwD/ Om07UwJGkvLllnwjQOMZ4BmoXx4KGyvcDFVVrMhAoK939DBFn66DVGB2rR3CoiK4rwVS UfGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iBg1uCqOePo2LDQD2c20wRoYMAK/OSTDbgOTeB8gv9s=; b=D8pqDrmgh0dE46jRdVHKt1y0QjbtkoWdWk8CeQlKTDz8e2a15cFahjq7PslnWXHONN yRJUNjH5wct/VgYJevjTN/loIsAnSuhzguDJDSDJ6g4cWUWORmPt9KRjkp1gp5ucunQ+ jIukfgCWjmMHzKozvz7uvI1/JPMVRiSDnhyKjQRpKPp9TShIMY9DafCKQ4dJp47SUu/W o09Pk5EZJj598ln9EhxOALBH2sz5/22ykFSAWZpNKXgWI6NthLXJpV64WOkoPA9+CWMa mcvKkxMZ7R+tNA64u+iyIPX5jWNlYHvelEfPXlgbJ4vQ/lZ9jemaRpfYYK+aWiq03Gbj dTTw== X-Gm-Message-State: APzg51AGXxghgtilJbXZVxDwwz8DcxFz5+35MmjMG5Bhbnka968GjutO 1DEsJlr2QoAjdnWiZeK9v7/AYA== X-Google-Smtp-Source: ANB0VdYbZmjm7lvjZzIrAgDIF4woMGj3O/Sn3M5tcK/PDoYspDA130nYXhZyi+digGGWYSWY/JEA5Q== X-Received: by 2002:a50:94b3:: with SMTP id s48-v6mr7142068eda.125.1535545438286; Wed, 29 Aug 2018 05:23:58 -0700 (PDT) Received: from titan.cnexlabs.com (6164211-cl69.boa.fiberby.dk. [193.106.164.211]) by smtp.gmail.com with ESMTPSA id f26-v6sm1752068edb.28.2018.08.29.05.23.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 29 Aug 2018 05:23:57 -0700 (PDT) From: Hans Holmberg To: Matias Bjorling Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Gonzales , Hans Holmberg Subject: [PATCH 6/7] lightnvm: pblk: fix up prints in pblk_read_check_rand Date: Wed, 29 Aug 2018 14:23:33 +0200 Message-Id: <1535545414-550-7-git-send-email-hans.ml.holmberg@owltronix.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1535545414-550-1-git-send-email-hans.ml.holmberg@owltronix.com> References: <1535545414-550-1-git-send-email-hans.ml.holmberg@owltronix.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Hans Holmberg The prefix when printing ppas in pblk_read_check_rand should be "rnd" not "seq", so fix this so we can differentiate between lba missmatches in random and sequential reads. Also change the print order so we align with pblk_read_check_seq, printing read lba first. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-read.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/lightnvm/pblk-read.c b/drivers/lightnvm/pblk-read.c index df3c4eb13be9..6d13763f2f6a 100644 --- a/drivers/lightnvm/pblk-read.c +++ b/drivers/lightnvm/pblk-read.c @@ -149,10 +149,10 @@ static void pblk_read_check_rand(struct pblk *pblk, struct nvm_rq *rqd, #ifdef CONFIG_NVM_PBLK_DEBUG struct ppa_addr *ppa_list = nvm_rq_to_ppa_list(rqd); - print_ppa(pblk, &ppa_list[j], "seq", j); + print_ppa(pblk, &ppa_list[j], "rnd", j); #endif pblk_err(pblk, "corrupted read LBA (%llu/%llu)\n", - lba, meta_lba); + meta_lba, lba); WARN_ON(1); }