| Message ID | 1574742858-23131-1-git-send-email-KC17041980@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] block/drbd/drbd_debugfs.c: Protect &connection->kref with resource->req_lock | expand |
On Tue, Nov 26, 2019 at 10:04:18AM +0530, kc27041980@gmail.com wrote: > From: KC27041980 <kc27041980@gmail.com> > > Protect &connection->kref by moving it under resource->req_lock. > > Signed-off-by: KC27041980 <kc27041980@gmail.com> We need a real name here, something you sign legal documents with. Please see the in-kernel documentation about submitting patches for all of the details. thanks, gre gk-h
diff --git a/drivers/block/drbd/drbd_debugfs.c b/drivers/block/drbd/drbd_debugfs.c index b3b9cd5..f6d75fa 100644 --- a/drivers/block/drbd/drbd_debugfs.c +++ b/drivers/block/drbd/drbd_debugfs.c @@ -363,11 +363,15 @@ static int in_flight_summary_show(struct seq_file *m, void *pos) struct drbd_connection *connection; unsigned long jif = jiffies; + spin_lock_irq(&resource->req_lock); connection = first_connection(resource); /* This does not happen, actually. * But be robust and prepare for future code changes. */ - if (!connection || !kref_get_unless_zero(&connection->kref)) + if (!connection || !kref_get_unless_zero(&connection->kref)) { + spin_unlock_irq(&resource->req_lock); return -ESTALE; + } + spin_unlock_irq(&resource->req_lock); /* BUMP me if you change the file format/content/presentation */ seq_printf(m, "v: %u\n\n", 0);