| Message ID | 1595233988-28342-1-git-send-email-jiufei.xue@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] block: delete unused Kconfig | expand |
On 7/20/20 2:33 AM, Jiufei Xue wrote: > Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com> > --- > block/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/block/Kconfig b/block/Kconfig > index 9357d73..d52c9bc 100644 > --- a/block/Kconfig > +++ b/block/Kconfig > @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY > config BLK_CGROUP_IOCOST > bool "Enable support for cost model based cgroup IO controller" > depends on BLK_CGROUP=y > - select BLK_RQ_IO_DATA_LEN > select BLK_RQ_ALLOC_TIME > help > Enabling this option enables the .weight interface for cost What's the difference between v1 and v2? A commit message would also be nice...
On 2020/7/20 下午11:49, Jens Axboe wrote: > On 7/20/20 2:33 AM, Jiufei Xue wrote: >> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com> >> --- >> block/Kconfig | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/block/Kconfig b/block/Kconfig >> index 9357d73..d52c9bc 100644 >> --- a/block/Kconfig >> +++ b/block/Kconfig >> @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY >> config BLK_CGROUP_IOCOST >> bool "Enable support for cost model based cgroup IO controller" >> depends on BLK_CGROUP=y >> - select BLK_RQ_IO_DATA_LEN >> select BLK_RQ_ALLOC_TIME >> help >> Enabling this option enables the .weight interface for cost > > What's the difference between v1 and v2? A commit message would > also be nice... > Sorry for the confusion. I have misspelled *unused* in patch v1. Thanks, Jiufei
On 7/20/20 7:50 PM, Jiufei Xue wrote: > > > On 2020/7/20 下午11:49, Jens Axboe wrote: >> On 7/20/20 2:33 AM, Jiufei Xue wrote: >>> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com> >>> --- >>> block/Kconfig | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/block/Kconfig b/block/Kconfig >>> index 9357d73..d52c9bc 100644 >>> --- a/block/Kconfig >>> +++ b/block/Kconfig >>> @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY >>> config BLK_CGROUP_IOCOST >>> bool "Enable support for cost model based cgroup IO controller" >>> depends on BLK_CGROUP=y >>> - select BLK_RQ_IO_DATA_LEN >>> select BLK_RQ_ALLOC_TIME >>> help >>> Enabling this option enables the .weight interface for cost >> >> What's the difference between v1 and v2? A commit message would >> also be nice... >> Sorry for the confusion. I have misspelled *unused* in patch v1. Ah I see. Can you send a v3 that has a simple commit message at least?
On 2020/7/21 上午9:51, Jens Axboe wrote: > On 7/20/20 7:50 PM, Jiufei Xue wrote: >> >> >> On 2020/7/20 下午11:49, Jens Axboe wrote: >>> On 7/20/20 2:33 AM, Jiufei Xue wrote: >>>> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com> >>>> --- >>>> block/Kconfig | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/block/Kconfig b/block/Kconfig >>>> index 9357d73..d52c9bc 100644 >>>> --- a/block/Kconfig >>>> +++ b/block/Kconfig >>>> @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY >>>> config BLK_CGROUP_IOCOST >>>> bool "Enable support for cost model based cgroup IO controller" >>>> depends on BLK_CGROUP=y >>>> - select BLK_RQ_IO_DATA_LEN >>>> select BLK_RQ_ALLOC_TIME >>>> help >>>> Enabling this option enables the .weight interface for cost >>> >>> What's the difference between v1 and v2? A commit message would >>> also be nice... >>> Sorry for the confusion. I have misspelled *unused* in patch v1. > > Ah I see. Can you send a v3 that has a simple commit message at least? > Of course. I will send v3 soon.
diff --git a/block/Kconfig b/block/Kconfig index 9357d73..d52c9bc 100644 --- a/block/Kconfig +++ b/block/Kconfig @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY config BLK_CGROUP_IOCOST bool "Enable support for cost model based cgroup IO controller" depends on BLK_CGROUP=y - select BLK_RQ_IO_DATA_LEN select BLK_RQ_ALLOC_TIME help Enabling this option enables the .weight interface for cost
Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com> --- block/Kconfig | 1 - 1 file changed, 1 deletion(-)