diff mbox series

block: wbt: Remove unnecessary invoking of wbt_update_limits in wbt_init

Message ID 1606702852-14157-1-git-send-email-lennychen@tencent.com (mailing list archive)
State New, archived
Headers show
Series block: wbt: Remove unnecessary invoking of wbt_update_limits in wbt_init | expand

Commit Message

Lei Chen Nov. 30, 2020, 2:20 a.m. UTC 
From: Lei Chen <lennychen@tencent.com>

It's unnecessary to call wbt_update_limits explicitly within wbt_init,
because it will be called in the following function wbt_queue_depth_changed.

Signed-off-by: Lei Chen <lennychen@tencent.com>
---
 block/blk-wbt.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jens Axboe Nov. 30, 2020, 6:10 p.m. UTC | #1 
On 11/29/20 7:20 PM, chenlei0x@gmail.com wrote:
> From: Lei Chen <lennychen@tencent.com>
> 
> It's unnecessary to call wbt_update_limits explicitly within wbt_init,
> because it will be called in the following function wbt_queue_depth_changed.

Applied, thanks.
diff mbox series

Patch

diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index fd41008..0321ca8 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -835,7 +835,6 @@  int wbt_init(struct request_queue *q)
 	rwb->enable_state = WBT_STATE_ON_DEFAULT;
 	rwb->wc = 1;
 	rwb->rq_depth.default_depth = RWB_DEF_DEPTH;
-	wbt_update_limits(rwb);
 
 	/*
 	 * Assign rwb and add the stats callback.