diff mbox series

rsxx: remove redundant NULL check

Message ID 1611222202-114248-1-git-send-email-abaci-bugfix@linux.alibaba.com (mailing list archive)
State New, archived
Headers show
Series rsxx: remove redundant NULL check | expand

Commit Message

Abaci Team Jan. 21, 2021, 9:43 a.m. UTC
Fix below warnings reported by coccicheck:
./drivers/block/rsxx/dma.c:948:3-8: WARNING: NULL check
before some freeing functions is not needed.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <abaci-bugfix@linux.alibaba.com>
---
 drivers/block/rsxx/dma.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Jens Axboe Jan. 26, 2021, 8:15 p.m. UTC | #1
On 1/21/21 2:43 AM, Yang Li wrote:
> Fix below warnings reported by coccicheck:
> ./drivers/block/rsxx/dma.c:948:3-8: WARNING: NULL check
> before some freeing functions is not needed.

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/block/rsxx/dma.c b/drivers/block/rsxx/dma.c
index 1914f54..0574f44 100644
--- a/drivers/block/rsxx/dma.c
+++ b/drivers/block/rsxx/dma.c
@@ -944,8 +944,7 @@  int rsxx_dma_setup(struct rsxx_cardinfo *card)
 			ctrl->done_wq = NULL;
 		}
 
-		if (ctrl->trackers)
-			vfree(ctrl->trackers);
+		vfree(ctrl->trackers);
 
 		if (ctrl->status.buf)
 			dma_free_coherent(&card->dev->dev, STATUS_BUFFER_SIZE8,