diff mbox series

lightnvm: Return the correct return value

Message ID 1618213134-21099-1-git-send-email-tiantao6@hisilicon.com (mailing list archive)
State New, archived
Headers show
Series lightnvm: Return the correct return value | expand

Commit Message

Tian Tao April 12, 2021, 7:38 a.m. UTC 
When memdup_user returns an error, memdup_user has two different return
values, use PTR_ERR to get the correct return value.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
 drivers/lightnvm/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Matias Bjorling April 13, 2021, 10:54 a.m. UTC | #1 
On 12/04/2021 09.38, Tian Tao wrote:
> When memdup_user returns an error, memdup_user has two different return
> values, use PTR_ERR to get the correct return value.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
>   drivers/lightnvm/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
> index 28ddcaa..42774be 100644
> --- a/drivers/lightnvm/core.c
> +++ b/drivers/lightnvm/core.c
> @@ -1257,7 +1257,7 @@ static long nvm_ioctl_info(struct file *file, void __user *arg)
>   
>   	info = memdup_user(arg, sizeof(struct nvm_ioctl_info));
>   	if (IS_ERR(info))
> -		return -EFAULT;
> +		return PTR_ERR(info);
>   
>   	info->version[0] = NVM_VERSION_MAJOR;
>   	info->version[1] = NVM_VERSION_MINOR;
Thanks, Tian. It has been pulled.
diff mbox series

Patch

diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c
index 28ddcaa..42774be 100644
--- a/drivers/lightnvm/core.c
+++ b/drivers/lightnvm/core.c
@@ -1257,7 +1257,7 @@  static long nvm_ioctl_info(struct file *file, void __user *arg)
 
 	info = memdup_user(arg, sizeof(struct nvm_ioctl_info));
 	if (IS_ERR(info))
-		return -EFAULT;
+		return PTR_ERR(info);
 
 	info->version[0] = NVM_VERSION_MAJOR;
 	info->version[1] = NVM_VERSION_MINOR;