| Message ID | 1635501029-81391-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: ataflop: Fix warning comparing pointer to 0 | expand |
On Fri, 29 Oct 2021 17:50:29 +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/block/ataflop.c:1464:20-21: WARNING comparing pointer to 0. > > Applied, thanks! [1/1] block: ataflop: Fix warning comparing pointer to 0 commit: df75db1fc1e5608271397de37cab43371bb838d2 Best regards,
diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c index 2622803..d14bdc3 100644 --- a/drivers/block/ataflop.c +++ b/drivers/block/ataflop.c @@ -1460,8 +1460,7 @@ static int floppy_revalidate(struct gendisk *disk) unsigned int drive = p - unit; if (test_bit(drive, &changed_floppies) || - test_bit(drive, &fake_change) || - p->disktype == 0) { + test_bit(drive, &fake_change) || !p->disktype) { if (UD.flags & FTD_MSG) printk(KERN_ERR "floppy: clear format %p!\n", UDT); BufferDrive = -1;
Fix the following coccicheck warning: ./drivers/block/ataflop.c:1464:20-21: WARNING comparing pointer to 0. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/block/ataflop.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)