From patchwork Tue Aug 2 10:58:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "baolex.ni" X-Patchwork-Id: 9259785 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2AE376089F for ; Tue, 2 Aug 2016 17:59:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23F54284B6 for ; Tue, 2 Aug 2016 17:59:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 17D8A28521; Tue, 2 Aug 2016 17:59:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B804E284F4 for ; Tue, 2 Aug 2016 17:59:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934717AbcHBR7S (ORCPT ); Tue, 2 Aug 2016 13:59:18 -0400 Received: from mga04.intel.com ([192.55.52.120]:44916 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755955AbcHBLgk (ORCPT ); Tue, 2 Aug 2016 07:36:40 -0400 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 02 Aug 2016 04:36:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743070808" Received: from shsibuild003.sh.intel.com ([10.239.146.225]) by FMSMGA003.fm.intel.com with ESMTP; 02 Aug 2016 04:36:38 -0700 From: Baole Ni To: mb@lightnvm.io, j.anaszewski@samsung.com, hal.rosenstock@gmail.com, dledford@redhat.com, sean.hefty@intel.com, bp@alien8.de Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com Subject: [PATCH 0310/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 18:58:59 +0800 Message-Id: <20160802105859.2140-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- drivers/lightnvm/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/core.c b/drivers/lightnvm/core.c index 160c1a6..8dec614 100644 --- a/drivers/lightnvm/core.c +++ b/drivers/lightnvm/core.c @@ -1032,7 +1032,7 @@ static const struct kernel_param_ops nvm_configure_by_str_event_param_ops = { #define MODULE_PARAM_PREFIX "lnvm." module_param_cb(configure_debug, &nvm_configure_by_str_event_param_ops, NULL, - 0644); + S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); #endif /* CONFIG_NVM_DEBUG */