From patchwork Tue Feb 14 13:47:36 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9572033 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A5D646045F for ; Tue, 14 Feb 2017 13:48:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9971927FA6 for ; Tue, 14 Feb 2017 13:48:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8DA9628174; Tue, 14 Feb 2017 13:48:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2BCF327FA6 for ; Tue, 14 Feb 2017 13:48:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753189AbdBNNsU (ORCPT ); Tue, 14 Feb 2017 08:48:20 -0500 Received: from verein.lst.de ([213.95.11.211]:50435 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752730AbdBNNrk (ORCPT ); Tue, 14 Feb 2017 08:47:40 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 794A568D56; Tue, 14 Feb 2017 14:47:36 +0100 (CET) Date: Tue, 14 Feb 2017 14:47:36 +0100 From: "hch@lst.de" To: Dexuan Cui Cc: "hch@lst.de" , Jens Axboe , Bart Van Assche , "hare@suse.com" , "hare@suse.de" , "Martin K. Petersen" , "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "jth@kernel.org" , Nick Meier , "Alex Ng (LIS)" , Long Li , "Adrian Suhov (Cloudbase Solutions SRL)" , "Chris Valean (Cloudbase Solutions SRL)" Subject: Re: Boot regression (was "Re: [PATCH] genhd: Do not hold event lock when scheduling workqueue elements") Message-ID: <20170214134736.GA19620@lst.de> References: <1486436195.2791.1.camel@sandisk.com> <9199d528-f220-5b77-d657-c510ca210067@kernel.dk> <20170208180314.GA17838@lst.de> <20170209130800.GA12057@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Dexuan, can you try the hack below for now? I disable the TUR call from sd_check_events, which I think your VM is hanging on. The checks it does on the sense data look a bit fishy, but so far I've not identified a possible root cause. diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 40b4038c019e..1502e87c2be9 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1457,9 +1457,13 @@ static unsigned int sd_check_events(struct gendisk *disk, unsigned int clearing) retval = -ENODEV; if (scsi_block_when_processing_errors(sdp)) { +#if 0 sshdr = kzalloc(sizeof(*sshdr), GFP_KERNEL); retval = scsi_test_unit_ready(sdp, SD_TIMEOUT, SD_MAX_RETRIES, sshdr); +#else + retval = 0; +#endif } /* failed to execute TUR, assume media not present */