From patchwork Thu Feb 16 20:10:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9578329 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 58EA8600C5 for ; Thu, 16 Feb 2017 20:11:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4CA3627317 for ; Thu, 16 Feb 2017 20:11:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 416E42866A; Thu, 16 Feb 2017 20:11:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BD93127317 for ; Thu, 16 Feb 2017 20:11:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932955AbdBPULE (ORCPT ); Thu, 16 Feb 2017 15:11:04 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:51053 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932740AbdBPULD (ORCPT ); Thu, 16 Feb 2017 15:11:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=e3bCFJQj8tA3MMbgP2d09TEccK0GspWeqlcIwf5l5b0=; b=sRJlSEe/hgp834GwwZBP8JYRP Vss4QdiTePukPJUA6Li88FLsds8xpTa/LPCe2dkIlOCfOxhrGjZwR4ddx/ugnNmBZuT9zVXH2mpto iqZiJycBGruVCEFgI4BMyBYyHPUA1T0QGWsRhbjp0DRk3YRix1Kg09BpEXnSlZo0eORaYvzJl82l9 jgVBafxoqwCLZ5R9qHcNFwJw7N4uJI+6sqjkZRp7VlqJjqHZMGm/FcQx+UZ1dLvi9/4/fAAFHlE8c x+fWMXkIhAMV00r2VDrj3WjfWnaVFpYYp4mPJWDj7Hcc+H/6J5YTsLA2fMdm153DvXW0g4+sVl18f ZDxnC13SQ==; Received: from clnet-p099-196.ikbnet.co.at ([83.175.99.196] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1ceSOI-0002Vw-Ui; Thu, 16 Feb 2017 20:11:01 +0000 From: Christoph Hellwig To: scott.bauer@intel.com, keith.busch@intel.com, jonathan.derrick@intel.com, axboe@fb.com Cc: linux-block@vger.kernel.org, linux-nvme@lists.infradead.org Subject: [PATCH 1/2] block/sed-opal: tone down not supported warnings Date: Thu, 16 Feb 2017 21:10:52 +0100 Message-Id: <20170216201053.1190-1-hch@lst.de> X-Mailer: git-send-email 2.11.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Not having OPAL or a sub-feature supported is an entirely normal condition for many drives, so don't warn about it. Keep the messages, but tone them down to debug only. Signed-off-by: Christoph Hellwig Reviewed-by: Scott Bauer --- block/sed-opal.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/sed-opal.c b/block/sed-opal.c index e95b8a57053d..bcdd5b6d02e8 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -387,16 +387,16 @@ static int opal_discovery0_end(struct opal_dev *dev) } if (!supported) { - pr_err("This device is not Opal enabled. Not Supported!\n"); + pr_debug("This device is not Opal enabled. Not Supported!\n"); return -EOPNOTSUPP; } if (!single_user) - pr_warn("Device doesn't support single user mode\n"); + pr_debug("Device doesn't support single user mode\n"); if (!found_com_id) { - pr_warn("Could not find OPAL comid for device. Returning early\n"); + pr_debug("Could not find OPAL comid for device. Returning early\n"); return -EOPNOTSUPP;; } @@ -1951,7 +1951,7 @@ void init_opal_dev(struct opal_dev *opal_dev, sec_send_recv *send_recv) mutex_init(&opal_dev->dev_lock); opal_dev->send_recv = send_recv; if (check_opal_support(opal_dev) < 0) - pr_warn("Opal is not supported on this device\n"); + pr_debug("Opal is not supported on this device\n"); opal_dev->initialized = true; } EXPORT_SYMBOL(init_opal_dev);