From patchwork Fri Jun 9 15:18:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mike Snitzer X-Patchwork-Id: 9778791 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C0AFD60393 for ; Fri, 9 Jun 2017 15:19:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE65A200F5 for ; Fri, 9 Jun 2017 15:19:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B180928652; Fri, 9 Jun 2017 15:19:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8BC35200F5 for ; Fri, 9 Jun 2017 15:19:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751577AbdFIPS7 (ORCPT ); Fri, 9 Jun 2017 11:18:59 -0400 Received: from mail-qt0-f193.google.com ([209.85.216.193]:34887 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbdFIPS6 (ORCPT ); Fri, 9 Jun 2017 11:18:58 -0400 Received: by mail-qt0-f193.google.com with SMTP id x58so15715409qtc.2; Fri, 09 Jun 2017 08:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2Snt8O+YSW9inOmZleH3e12togA/aZ5RgL8YjV7EuMI=; b=XamxbXJ6Qo25o/XHlcfYAQKORAE3T0P3z9hSuGa1vo/82CQMoZ6Cj3PzBQ8E109YvW nKaWll9ALud6CtK8OQaSAmeHh+lUPWeuDP0PZqe2Hkyjrqv1CaCcpeCBsmljZqXy+2wD tHu9swfQzqO6ciYVtkiKuYqNz3MkTBKHJH1k0oT6WKFDyAVP7OdaJlqygCb4+04AurjG GJJPHcwsPS64AY+Bqp+FUiEZkjIElou9/3y7gQdK3MfPueGEcyAIEh8TCEG9Guj5dPfv CgPM63kLAOJL3o69qR1RIi49J0DhNu54g6eJZ1+DJfNYotN+0fj7FXVYXWDKSguDiuVh MkWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=2Snt8O+YSW9inOmZleH3e12togA/aZ5RgL8YjV7EuMI=; b=Ehw6uCEPx/MbVw1PAO9lvkTkBzOheKzJKX6Hs9/YRdLZ6QfJZZesASfCRnojeuLOKI ZlZiq0L8z2CoX4dd9ItJNACF4s7JYDQA1jDWW4wQiBIcaSBGLmTXN3LYsFm4wO2Tbduk UdkqiKMlw4viV4LF0xLhDJfiY7stsDp3IvGZBWK+0mj29Zeza+RCmevJ3EQDsmzKLIy7 e1N1E2Vpp6MgdrtPYQ1UuTGaNdz9KnJdKvoqp/DpLY1LY9ec/RgfnjdAbEXy0anvgCAy OrxesIG5axNlnNIJhk2aEEQvBccnYhc5VvN58kID+Tf9PZuITKrsn7d1JuTYpDxkoKR2 J4xA== X-Gm-Message-State: AKS2vOxckwvyk/U8rZV2o68Sb4uuyufLxYtG9mafFYdlLh6h/twkiT1d 6xZf6Jtir8xUuUdziPk= X-Received: by 10.237.47.228 with SMTP id m91mr2891458qtd.242.1497021537572; Fri, 09 Jun 2017 08:18:57 -0700 (PDT) Received: from localhost ([66.187.232.66]) by smtp.gmail.com with ESMTPSA id x78sm836412qkb.44.2017.06.09.08.18.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Jun 2017 08:18:56 -0700 (PDT) Date: Fri, 9 Jun 2017 11:18:55 -0400 From: Mike Snitzer To: Jens Axboe Cc: Christoph Hellwig , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-btrfs@vger.kernel.org Subject: Re: dedicated error codes for the block layer V3 Message-ID: <20170609151854.GA74154@redhat.com> References: <20170603073806.2046-1-hch@lst.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jun 08 2017 at 11:42am -0400, Jens Axboe wrote: > On 06/03/2017 01:37 AM, Christoph Hellwig wrote: > > This series introduces a new blk_status_t error code type for the block > > layer so that we can have tigher control and explicit semantics for > > block layer errors. > > > > All but the last three patches are cleanups that lead to the new type. > > > > The series it mostly limited to the block layer and drivers, and touching > > file systems a little bit. The only major exception is btrfs, which > > does funny things with bios and thus sees a larger amount of propagation > > of the new blk_status_t. > > > > A git tree is also available at: > > > > git://git.infradead.org/users/hch/block.git block-errors > > > > gitweb: > > > > http://git.infradead.org/users/hch/block.git/shortlog/refs/heads/block-errors > > > > Note the the two biggest patches didn't make it to linux-block and > > linux-btrfs last time. If you didn't get them they are available in > > the git tree above. Unfortunately there is no easy way to split them > > up. > > Mike, can you take a look at the dm bits in this series? I'd like to get > this queued up, but I'd also greatly prefer if the dm patches had sign > off from your end. Hey Jens, All looks to be done properly to me. Though there are various weird partial indents, e.g.: @@ -2820,7 +2821,8 @@ static int cache_map(struct dm_target *ti, struct bio *bio) return r; } -static int cache_end_io(struct dm_target *ti, struct bio *bio, int *error) +static int cache_end_io(struct dm_target *ti, struct bio *bio, + blk_status_t *error) { struct cache *cache = ti->private; unsigned long flags; But I can let these go (will clean them up if/when I make changes to the various locations in the future)... You can add my s-o-b tag to all commits in this series that touch DM: Signed-off-by: Mike Snitzer But I'd also like the DM minor version bumped to reflect all the error code churn, please include this patch, thanks! From: Mike Snitzer Date: Fri, 9 Jun 2017 11:02:40 -0400 Subject: [PATCH] dm: bump DM_VERSION_MINOR in response to target method error code changes Signed-off-by: Mike Snitzer --- include/uapi/linux/dm-ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/uapi/linux/dm-ioctl.h b/include/uapi/linux/dm-ioctl.h index 4bf9f1e..2f6c77a 100644 --- a/include/uapi/linux/dm-ioctl.h +++ b/include/uapi/linux/dm-ioctl.h @@ -267,9 +267,9 @@ enum { #define DM_DEV_SET_GEOMETRY _IOWR(DM_IOCTL, DM_DEV_SET_GEOMETRY_CMD, struct dm_ioctl) #define DM_VERSION_MAJOR 4 -#define DM_VERSION_MINOR 35 +#define DM_VERSION_MINOR 36 #define DM_VERSION_PATCHLEVEL 0 -#define DM_VERSION_EXTRA "-ioctl (2016-06-23)" +#define DM_VERSION_EXTRA "-ioctl (2017-06-09)" /* Status bits */ #define DM_READONLY_FLAG (1 << 0) /* In/Out */