diff mbox

[v2] blk-mq-debugfs: Add names for recently added flags

Message ID 20170818225254.30706-1-bart.vanassche@wdc.com (mailing list archive)
State New, archived
Headers show

Commit Message

Bart Van Assche Aug. 18, 2017, 10:52 p.m. UTC
The symbolic constants QUEUE_FLAG_SCSI_PASSTHROUGH, QUEUE_FLAG_QUIESCED
and REQ_NOWAIT are missing from blk-mq-debugfs.c. Add these to
blk-mq-debugfs.c such that these appear as names in debugfs instead of
as numbers.

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Omar Sandoval <osandov@fb.com>
Cc: Hannes Reinecke <hare@suse.com>
---

v2: changed "PASSTHROUGH" into "SCSI_PASSTHROUGH".

 block/blk-mq-debugfs.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Bart Van Assche Aug. 24, 2017, 11:30 p.m. UTC | #1
On Fri, 2017-08-18 at 15:52 -0700, Bart Van Assche wrote:
> The symbolic constants QUEUE_FLAG_SCSI_PASSTHROUGH, QUEUE_FLAG_QUIESCED

> and REQ_NOWAIT are missing from blk-mq-debugfs.c. Add these to

> blk-mq-debugfs.c such that these appear as names in debugfs instead of

> as numbers.


Hi Jens,

Have you already had the time to have a look at this patch?

Thanks,

Bart.
Omar Sandoval Aug. 24, 2017, 11:49 p.m. UTC | #2
On Thu, Aug 24, 2017 at 11:30:46PM +0000, Bart Van Assche wrote:
> On Fri, 2017-08-18 at 15:52 -0700, Bart Van Assche wrote:
> > The symbolic constants QUEUE_FLAG_SCSI_PASSTHROUGH, QUEUE_FLAG_QUIESCED
> > and REQ_NOWAIT are missing from blk-mq-debugfs.c. Add these to
> > blk-mq-debugfs.c such that these appear as names in debugfs instead of
> > as numbers.
> 
> Hi Jens,
> 
> Have you already had the time to have a look at this patch?
> 
> Thanks,
> 
> Bart.

Reviewed-by: Omar Sandoval <osandov@fb.com>

FWIW
Jens Axboe Aug. 25, 2017, 2:07 p.m. UTC | #3
On 08/18/2017 04:52 PM, Bart Van Assche wrote:
> The symbolic constants QUEUE_FLAG_SCSI_PASSTHROUGH, QUEUE_FLAG_QUIESCED
> and REQ_NOWAIT are missing from blk-mq-debugfs.c. Add these to
> blk-mq-debugfs.c such that these appear as names in debugfs instead of
> as numbers.

Added for 4.13, thanks.
diff mbox

Patch

diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
index e53b6129ca5a..980e73095643 100644
--- a/block/blk-mq-debugfs.c
+++ b/block/blk-mq-debugfs.c
@@ -73,6 +73,8 @@  static const char *const blk_queue_flag_name[] = {
 	QUEUE_FLAG_NAME(STATS),
 	QUEUE_FLAG_NAME(POLL_STATS),
 	QUEUE_FLAG_NAME(REGISTERED),
+	QUEUE_FLAG_NAME(SCSI_PASSTHROUGH),
+	QUEUE_FLAG_NAME(QUIESCED),
 };
 #undef QUEUE_FLAG_NAME
 
@@ -263,6 +265,7 @@  static const char *const cmd_flag_name[] = {
 	CMD_FLAG_NAME(RAHEAD),
 	CMD_FLAG_NAME(BACKGROUND),
 	CMD_FLAG_NAME(NOUNMAP),
+	CMD_FLAG_NAME(NOWAIT),
 };
 #undef CMD_FLAG_NAME