diff mbox

skd: Uninitialized variable in skd_isr_completion_posted()

Message ID 20170823104048.w4vdvlp72ug5ackq@mwanda (mailing list archive)
State New, archived
Headers show

Commit Message

Dan Carpenter Aug. 23, 2017, 10:44 a.m. UTC 
Someone got too agressive about removing initializations and
accidentally removed the "rc = 0;" which is required.

Fixes: c830da8cbc7b ("skd: Remove superfluous initializations from skd_isr_completion_posted()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Comments

Jens Axboe Aug. 23, 2017, 2:36 p.m. UTC | #1 
On 08/23/2017 04:44 AM, Dan Carpenter wrote:
> Someone got too agressive about removing initializations and
> accidentally removed the "rc = 0;" which is required.

Thanks Dan, applied.
diff mbox

Patch

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 9b99081a623c..35938ee0651a 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -1499,7 +1499,7 @@  static int skd_isr_completion_posted(struct skd_device *skdev,
 	u8 cmp_status;
 	u8 cmp_cycle;
 	u32 cmp_bytes;
-	int rc;
+	int rc = 0;
 	int processed = 0;
 
 	lockdep_assert_held(&skdev->lock);