| Message ID | 20180104224623.8944-4-keith.busch@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Jan 04 2018 at 5:46pm -0500, Keith Busch <keith.busch@intel.com> wrote: > This patch provides a common decoder for block status that may be retried > so various entities wishing to consult this do not have to duplicate > this decision. > > Signed-off-by: Keith Busch <keith.busch@intel.com> Acked-by: Mike Snitzer <snitzer@redhat.com>
On 01/04/2018 11:46 PM, Keith Busch wrote: > This patch provides a common decoder for block status that may be retried > so various entities wishing to consult this do not have to duplicate > this decision. > > Signed-off-by: Keith Busch <keith.busch@intel.com> > --- > include/linux/blk_types.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h > index a1e628e032da..b6a8723b493c 100644 > --- a/include/linux/blk_types.h > +++ b/include/linux/blk_types.h > @@ -39,6 +39,22 @@ typedef u8 __bitwise blk_status_t; > > #define BLK_STS_AGAIN ((__force blk_status_t)12) > > +static inline bool blk_retryable(blk_status_t error) > +{ > + switch (error) { > + case BLK_STS_NOTSUPP: > + case BLK_STS_NOSPC: > + case BLK_STS_TARGET: > + case BLK_STS_NEXUS: > + case BLK_STS_MEDIUM: > + case BLK_STS_PROTECTION: > + return false; > + } > + > + /* Anything else could be a path failure, so should be retried */ > + return true; > +} > + > struct blk_issue_stat { > u64 stat; > }; > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
> +static inline bool blk_retryable(blk_status_t error)
The naming isn't really useful - it is about the fact that it's
worth retrying on another path. So please chose a better name,
and add a kerneldoc comment describing it.
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index a1e628e032da..b6a8723b493c 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -39,6 +39,22 @@ typedef u8 __bitwise blk_status_t; #define BLK_STS_AGAIN ((__force blk_status_t)12) +static inline bool blk_retryable(blk_status_t error) +{ + switch (error) { + case BLK_STS_NOTSUPP: + case BLK_STS_NOSPC: + case BLK_STS_TARGET: + case BLK_STS_NEXUS: + case BLK_STS_MEDIUM: + case BLK_STS_PROTECTION: + return false; + } + + /* Anything else could be a path failure, so should be retried */ + return true; +} + struct blk_issue_stat { u64 stat; };
This patch provides a common decoder for block status that may be retried so various entities wishing to consult this do not have to duplicate this decision. Signed-off-by: Keith Busch <keith.busch@intel.com> --- include/linux/blk_types.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)