| Message ID | 20180119174053.GA967@localhost.didichuxing.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 1/19/18 10:40 AM, weiping zhang wrote: > use queue_is_rq_based instead of open code. > > Signed-off-by: weiping zhang <zhangweiping@didichuxing.com> > --- > block/blk-throttle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-throttle.c b/block/blk-throttle.c > index 96ad326..457e985 100644 > --- a/block/blk-throttle.c > +++ b/block/blk-throttle.c > @@ -2456,7 +2456,7 @@ void blk_throtl_register_queue(struct request_queue *q) > td->throtl_slice = DFL_THROTL_SLICE_HD; > #endif > > - td->track_bio_latency = !q->mq_ops && !q->request_fn; > + td->track_bio_latency = !(queue_is_rq_based(q)); Kill the extra parenthesis here.
2018-01-20 3:58 GMT+08:00 Jens Axboe <axboe@kernel.dk>: > On 1/19/18 10:40 AM, weiping zhang wrote: >> use queue_is_rq_based instead of open code. >> >> Signed-off-by: weiping zhang <zhangweiping@didichuxing.com> >> --- >> block/blk-throttle.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/block/blk-throttle.c b/block/blk-throttle.c >> index 96ad326..457e985 100644 >> --- a/block/blk-throttle.c >> +++ b/block/blk-throttle.c >> @@ -2456,7 +2456,7 @@ void blk_throtl_register_queue(struct request_queue *q) >> td->throtl_slice = DFL_THROTL_SLICE_HD; >> #endif >> >> - td->track_bio_latency = !q->mq_ops && !q->request_fn; >> + td->track_bio_latency = !(queue_is_rq_based(q)); > > Kill the extra parenthesis here. Oh, kill it at V2. > -- > Jens Axboe >
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 96ad326..457e985 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -2456,7 +2456,7 @@ void blk_throtl_register_queue(struct request_queue *q) td->throtl_slice = DFL_THROTL_SLICE_HD; #endif - td->track_bio_latency = !q->mq_ops && !q->request_fn; + td->track_bio_latency = !(queue_is_rq_based(q)); if (!td->track_bio_latency) blk_stat_enable_accounting(q); }
use queue_is_rq_based instead of open code. Signed-off-by: weiping zhang <zhangweiping@didichuxing.com> --- block/blk-throttle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)