From patchwork Thu Mar 15 15:08:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10284713 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A241A602BD for ; Thu, 15 Mar 2018 15:08:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9247828B0B for ; Thu, 15 Mar 2018 15:08:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 83C6A28B1C; Thu, 15 Mar 2018 15:08:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3E17228B1E for ; Thu, 15 Mar 2018 15:08:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748AbeCOPIc (ORCPT ); Thu, 15 Mar 2018 11:08:32 -0400 Received: from esa2.hgst.iphmx.com ([68.232.143.124]:46680 "EHLO esa2.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752759AbeCOPIa (ORCPT ); Thu, 15 Mar 2018 11:08:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1521127619; x=1552663619; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=LYPx6xAcZHS8KJwSg1Bj2gAxDhgw6aZmpxWUKIpohm0=; b=akFCrY9abIbw6q8M3LZKGaDnZ8f5sjZv3/5g9HEsn24QmKeCwnMquL59 M2m6Pu42Xd48fo8oJZgiYfoWLJYcdsHU+7Dt4foruJTC+7dI/PwYphu9d XlL6Z1P7A6uKDXt/g0x8Br1UJGaVr8W2Fw2KP6LloB2PZuyTJxvWPHkMQ LRCitGyDZLeNIytL6Xz+/zE9Qnkr/Fs+vwxVyT8ApQdIz+iMcVRyxatoH buPV1J60qhFNFAlGUtVOJ8JdZs4t0YSi6b5gCAgvhdOLd/VmbvabKZvzY gn0gJ2QUG/7lC/RhfCq8FmGM4m1SehFpHuG4p/ogsitfwR94lJYwf8bbL g==; X-IronPort-AV: E=Sophos;i="5.47,471,1515427200"; d="scan'208";a="170233273" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 15 Mar 2018 23:26:38 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP; 15 Mar 2018 08:01:14 -0700 Received: from thinkpad-bart.sdcorp.global.sandisk.com (HELO thinkpad-bart.int.fusionio.com) ([10.11.171.236]) by uls-op-cesaip02.wdc.com with ESMTP; 15 Mar 2018 08:08:17 -0700 From: Bart Van Assche To: Michael Lyle , Kent Overstreet , Coly Li Cc: linux-block@vger.kernel.org, Christoph Hellwig , Bart Van Assche Subject: [PATCH 11/16] bcache: Check the d->disk pointer before using it Date: Thu, 15 Mar 2018 08:08:09 -0700 Message-Id: <20180315150814.9412-12-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180315150814.9412-1-bart.vanassche@wdc.com> References: <20180315150814.9412-1-bart.vanassche@wdc.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since bcache_device_free() checks the d->disk pointer I think that means that that pointer can be NULL. Hence test that pointer before using it. This was detected by smatch. Signed-off-by: Bart Van Assche Reviewed-by: Coly Li --- drivers/md/bcache/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index d19a44cd1fd7..39bec137f636 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -742,7 +742,7 @@ static void bcache_device_free(struct bcache_device *d) { lockdep_assert_held(&bch_register_lock); - pr_info("%s stopped", d->disk->disk_name); + pr_info("%s stopped", d->disk ? d->disk->disk_name : "(?)"); if (d->c) bcache_device_detach(d);